Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(addon-viewport): editable width/height #12627

Closed
wants to merge 3 commits into from

Conversation

AndrewLeedham
Copy link
Contributor

This is still a WIP.

Issue: #12586

What I did

  • Added a NumericInput component to @storybook/components
  • Used the new NumericInput in place of the width/height labels in the @storybook/addon-viewport toolbar.
  • Adjusted the way styles are applied from the @storybook/addon-viewport plugin, to work with the new inputs.

How to test

  • Chromatic screenshots for the NumericInput.

@stale
Copy link

stale bot commented Dec 25, 2020

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

@stale stale bot added the inactive label Dec 25, 2020
@AndrewLeedham
Copy link
Contributor Author

Still a WIP, just haven't found the time to finish it off.

@stale stale bot removed the inactive label Dec 25, 2020
@stale
Copy link

stale bot commented Jan 9, 2022

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

@ndelangen
Copy link
Member

@AndrewLeedham I'll close the PR for now. If you're able to work on it again, we can re-open.

Thank you for the time and effort you've put into this.

@ndelangen ndelangen closed this Jun 30, 2022
@yannbf yannbf mentioned this pull request Apr 20, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants