New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
React: Update react-docgen
to 6.0.1
#22324
Conversation
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much @danez !! Will discuss with the team and figure out a path forward here. Congratulations on your upcoming release 🚀
I already fixed some of the typescript issues, but haven't released yet because I found more TypeScript issues. Will push here once the next version is out. |
I fixed the Typescript issues on my side, the remaining ones I am not sure what to do about. It seems you are validating external types with your own tsconfig. So not sure what I can do about this. |
react-docgen
to 6.0.0-rc.9
react-docgen
to 6.0.0-rc.9
react-docgen
to 6.0.1
@danez I have tested this out in another branch and it's working great. You can see my instructions for "how to test" on this PR #23825. Please kick the tires and let me know what you think! Unfortunately, the logic that converts Amazing job on the release and huge shout out to you and to @phated for his work on resolvers -- so exciting to see this finally in action. |
What I did
I updated
react-docgen
to its latests version6.0.1
.Feel free to tell me if there is more work I need to do, or feel free to take over this PR and make it ready for merge. My initial goal is to see if an update is possible and if there are exports from
react-docgen
missing (which there were).How to test
Honestly I have no idea how to test. I tried
yarn start
but that fails with an error from yarnChecklist
MIGRATION.MD
Maintainers
make sure to add the
ci:merged
orci:daily
GH label to it.["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]