Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React: Update react-docgen to 6.0.1 #22324

Merged
merged 8 commits into from Oct 4, 2023
Merged

Conversation

danez
Copy link
Contributor

@danez danez commented Apr 30, 2023

What I did

I updated react-docgen to its latests version 6.0.1.

Feel free to tell me if there is more work I need to do, or feel free to take over this PR and make it ready for merge. My initial goal is to see if an update is possible and if there are exports from react-docgen missing (which there were).

How to test

Honestly I have no idea how to test. I tried yarn start but that fails with an error from yarn

Cannot link @storybook/react-vite into before-storybook@workspace:. dependency @vitejs/plugin-react@npm:3.1.0 [7f3e5] conflicts with parent dependency @vitejs/plugin-react@npm:4.0.0

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@socket-security
Copy link

socket-security bot commented Apr 30, 2023

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much @danez !! Will discuss with the team and figure out a path forward here. Congratulations on your upcoming release 🚀

@danez danez changed the title update react-docgen to 6.0.0-rc.7 update react-docgen to 6.0.0-rc.8 Apr 30, 2023
@danez
Copy link
Contributor Author

danez commented May 1, 2023

I already fixed some of the typescript issues, but haven't released yet because I found more TypeScript issues. Will push here once the next version is out.

@danez danez changed the title update react-docgen to 6.0.0-rc.8 update react-docgen to 6.0.0-rc.9 May 20, 2023
@danez
Copy link
Contributor Author

danez commented May 20, 2023

I fixed the Typescript issues on my side, the remaining ones I am not sure what to do about. It seems you are validating external types with your own tsconfig. So not sure what I can do about this.

@danez danez marked this pull request as ready for review May 22, 2023 11:42
@ndelangen ndelangen changed the title update react-docgen to 6.0.0-rc.9 React: Update react-docgen to 6.0.0-rc.9 Jun 21, 2023
@danez danez changed the title React: Update react-docgen to 6.0.0-rc.9 React: Update react-docgen to 6.0.1 Jun 21, 2023
@shilman
Copy link
Member

shilman commented Aug 14, 2023

@danez I have tested this out in another branch and it's working great. You can see my instructions for "how to test" on this PR #23825. Please kick the tires and let me know what you think!

Unfortunately, the logic that converts react-docgen output to ArgTypes (Storybook's representation of the same) is pretty dicey, so we'll need to update that to fully support react-docgen. But now that you have resolver support, I think we'll dedicate some time to improving that and will make react-docgen the default in Storybook 8.0.

Amazing job on the release and huge shout out to you and to @phated for his work on resolvers -- so exciting to see this finally in action.

@valentinpalkovic
Copy link
Contributor

@shilman Does #23825 replace this PR? And if so, can we close it?

@shilman shilman merged commit e874745 into storybookjs:next Oct 4, 2023
50 of 51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants