Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Builder-vite: Fix lib/channels dependency #23049

Merged
merged 1 commit into from
Jun 13, 2023
Merged

Builder-vite: Fix lib/channels dependency #23049

merged 1 commit into from
Jun 13, 2023

Conversation

ndelangen
Copy link
Member

@ndelangen ndelangen commented Jun 13, 2023 •
edited
Loading

@yannbf you ran into this

@ndelangen ndelangen self-assigned this Jun 13, 2023
@ndelangen ndelangen requested a review from yannbf June 13, 2023 14:04
@ndelangen ndelangen added the bug label Jun 13, 2023
@ndelangen ndelangen changed the title Bug: Ddd the missing dependency after the change to use lib/channels Bug: Add the missing dependency after the change to use lib/channels Jun 13, 2023
@ndelangen ndelangen merged commit 617e84f into next Jun 13, 2023
60 of 63 checks passed
@ndelangen ndelangen deleted the norbert/fix-vite-builder-missing-channels branch June 13, 2023 14:41
@github-actions github-actions bot mentioned this pull request Jun 13, 2023
Merged
42 tasks
@shilman shilman changed the title Bug: Add the missing dependency after the change to use lib/channels Builder-vite: Fix lib/channels dependencies Jun 14, 2023
@shilman shilman changed the title Builder-vite: Fix lib/channels dependencies Builder-vite: Fix lib/channels dependency Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yannbf yannbf Awaiting requested review from yannbf

Assignees

@ndelangen ndelangen

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@ndelangen