Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update button-story.ts.mdx #23158

Merged
merged 1 commit into from
Jun 20, 2023
Merged

Update button-story.ts.mdx #23158

merged 1 commit into from
Jun 20, 2023

Conversation

jared-christensen
Copy link
Contributor

The type on Primary was not working so I changed it.

The type on Primary was not working so I changed it.
@jonniebigodes jonniebigodes self-assigned this Jun 20, 2023
@jonniebigodes jonniebigodes added documentation patch:yes Bugfix & documentation PR that need to be picked to main branch labels Jun 20, 2023
@jonniebigodes
Copy link
Contributor

@jared-christensen, thanks for taking the time to put together this pull request and help us improve the documentation. We appreciate it 🙏 ! I've checked, and all is good on my end. And will merge after the checklist clears.

One thing that I wanted to ask you, would you be interested in vetting and updating the html snippets where required and also taking a pass at the remainder documentation and adding the missing ones?

Let me know, and we'll go from there.

Looking forward to hearing from you.

Have a fantastic day.

Stay safe

@jared-christensen
Copy link
Contributor Author

Thanks for thinking of me for this! My main focus is on Stencil right now, so I might not be the best person to comb through all the HTML snippets in the docs.

That being said, I'm all about improving things where I can. If I spot something off, I'll definitely whip up a PR. In fact, I've already got my eye on a spot that mentions Stencil in the docs that could use some love.

Appreciate you reaching out, and looking forward to pitching in where I can.

Cheers!

@jonniebigodes
Copy link
Contributor

No need to thank whatsoever. And appreciate the follow-up and interest in helping us out. Looking forward to seeing the pull request up and if you're ok with it, tag me in it, and I'll be more than glad to review it.

@jonniebigodes jonniebigodes merged commit 6c0a764 into storybookjs:next Jun 20, 2023
57 of 58 checks passed
JReinhold pushed a commit that referenced this pull request Jun 20, 2023
Update button-story.ts.mdx

(cherry picked from commit 6c0a764)
JReinhold pushed a commit that referenced this pull request Jun 20, 2023
Update button-story.ts.mdx

(cherry picked from commit 6c0a764)
JReinhold pushed a commit that referenced this pull request Jun 21, 2023
Update button-story.ts.mdx

(cherry picked from commit 6c0a764)
JReinhold pushed a commit that referenced this pull request Jun 21, 2023
Update button-story.ts.mdx

(cherry picked from commit 6c0a764)
JReinhold pushed a commit that referenced this pull request Jun 21, 2023
Update button-story.ts.mdx

(cherry picked from commit 6c0a764)
JReinhold pushed a commit that referenced this pull request Jun 21, 2023
Update button-story.ts.mdx

(cherry picked from commit 6c0a764)
JReinhold pushed a commit that referenced this pull request Jun 21, 2023
Update button-story.ts.mdx

(cherry picked from commit 6c0a764)
JReinhold pushed a commit that referenced this pull request Jun 21, 2023
Update button-story.ts.mdx

(cherry picked from commit 6c0a764)
JReinhold pushed a commit that referenced this pull request Jun 21, 2023
Update button-story.ts.mdx

(cherry picked from commit 6c0a764)
JReinhold pushed a commit that referenced this pull request Jun 21, 2023
Update button-story.ts.mdx

(cherry picked from commit 6c0a764)
JReinhold pushed a commit that referenced this pull request Jun 21, 2023
Update button-story.ts.mdx

(cherry picked from commit 6c0a764)
JReinhold pushed a commit that referenced this pull request Jun 21, 2023
Update button-story.ts.mdx

(cherry picked from commit 6c0a764)
JReinhold pushed a commit that referenced this pull request Jun 22, 2023
Update button-story.ts.mdx

(cherry picked from commit 6c0a764)
@github-actions github-actions bot mentioned this pull request Jun 22, 2023
18 tasks
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants