Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core: Migrate @storybook/core-server to strict TypeScript #23182

Merged
merged 11 commits into from
Jul 25, 2023
Merged

Core: Migrate @storybook/core-server to strict TypeScript #23182

merged 11 commits into from
Jul 25, 2023

Conversation

stilt0n
Copy link
Contributor

@stilt0n stilt0n commented Jun 22, 2023

Part of #22176

What I did

Migrate @storybook/core-server to strict-ts

How to test

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@stilt0n stilt0n marked this pull request as draft June 22, 2023 05:11
@stilt0n stilt0n marked this pull request as ready for review July 20, 2023 21:51
@ndelangen ndelangen added build Internal-facing build tooling & test updates ci:normal patch:no labels Jul 24, 2023
@stilt0n stilt0n changed the title migrate @storybook/core-server to strict TS Build: Migrate @storybook/core-server to strict TS Jul 24, 2023
@JReinhold JReinhold changed the title Build: Migrate @storybook/core-server to strict TS Core: Migrate @storybook/core-server to strict TypeScript Jul 25, 2023
@ndelangen ndelangen self-assigned this Jul 25, 2023
@ndelangen ndelangen merged commit a4e44fd into storybookjs:next Jul 25, 2023
45 checks passed
This was referenced Jul 25, 2023
Merged
Closed
@stilt0n stilt0n deleted the strict-types branch July 27, 2023 05:48
@JReinhold JReinhold mentioned this pull request Jul 27, 2023
Merged
5 tasks
@JReinhold JReinhold mentioned this pull request Jul 27, 2023
Closed
@yannbf yannbf mentioned this pull request Aug 2, 2023
Merged
5 tasks
This was referenced Aug 19, 2023
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndelangen ndelangen ndelangen approved these changes

@JReinhold JReinhold Awaiting requested review from JReinhold

@tmeasday tmeasday Awaiting requested review from tmeasday

@shilman shilman Awaiting requested review from shilman

Assignees

@ndelangen ndelangen

Labels
build Internal-facing build tooling & test updates ci:normal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@stilt0n @ndelangen