Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addon actions: replace eval with function name assignment #2321

Merged
merged 1 commit into from
Nov 15, 2017

Conversation

Hypnosphi
Copy link
Member

Issue: #1123

Although one can't assign function names directly like fn.name = 'foo', it's possible to do that using Object.defineProperty

@Hypnosphi Hypnosphi added addon: actions bug cleanup Minor cleanup style change that won't show up in release changelog labels Nov 15, 2017
@codecov
Copy link

codecov bot commented Nov 15, 2017

Codecov Report

Merging #2321 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2321   +/-   ##
=======================================
  Coverage   21.19%   21.19%           
=======================================
  Files         283      283           
  Lines        6156     6156           
  Branches      722      722           
=======================================
  Hits         1305     1305           
  Misses       4310     4310           
  Partials      541      541
Impacted Files Coverage Δ
addons/actions/src/preview.js 50% <100%> (ø) ⬆️
app/react/src/server/config/babel.js 0% <0%> (-100%) ⬇️
app/react/src/server/babel_config.js 0% <0%> (-77.42%) ⬇️
app/react/src/server/utils.js 0% <0%> (-53.58%) ⬇️
app/vue/src/server/utils.js 53.57% <0%> (+53.57%) ⬆️
app/vue/src/server/babel_config.js 77.41% <0%> (+77.41%) ⬆️
app/vue/src/server/config/babel.js 100% <0%> (+100%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 969aadb...7c72d40. Read the comment docs.

@Hypnosphi Hypnosphi merged commit e23face into master Nov 15, 2017
@Hypnosphi Hypnosphi deleted the remove-actions-eval branch November 15, 2017 23:56
@Hypnosphi Hypnosphi added merged and removed merged labels Nov 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
addon: actions bug cleanup Minor cleanup style change that won't show up in release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants