Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release tooling: Label merges as "release" #23219

Merged
merged 1 commit into from
Jun 27, 2023
Merged

Conversation

JReinhold
Copy link
Contributor

Follow-up to #23198

What I did

#23198 introduces the "release" label for release PRs, that also ensures that CI runs are only triggered with ci:* labels.

This PR changes the "merge-only"/"unreleasable" patch releases to also get the "release" label.

This might technically be less correct, but I think that's okay, given this will save on CI runs and are easily filterable anyway if you ever want to use the labels for searching.

How to test

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@JReinhold JReinhold self-assigned this Jun 26, 2023
@JReinhold JReinhold added patch:yes Bugfix & documentation PR that need to be picked to main branch build Internal-facing build tooling & test updates labels Jun 26, 2023
@JReinhold JReinhold merged commit 156bd6e into next Jun 27, 2023
40 of 46 checks passed
@github-actions github-actions bot mentioned this pull request Jun 27, 2023
18 tasks
shilman pushed a commit that referenced this pull request Jun 27, 2023
Release tooling: Label merges as "release"

(cherry picked from commit 156bd6e)
@JReinhold JReinhold added the patch:done Patch/release PRs already cherry-picked to main/release branch label Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Internal-facing build tooling & test updates patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants