Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependencies: Bump @sveltejs/vite-plugin-svelte #23233

Merged
merged 5 commits into from
Jul 12, 2023
Merged

Conversation

JReinhold
Copy link
Contributor

@JReinhold JReinhold commented Jun 27, 2023

I believe @sveltejs/vite-plugin-svelte v2.4.1 has a bug with TypeScript types and @sveltejs/vite-plugin-svelte-inspector that got fixed in v2.4.2.

The bug makes our internal TS checks fail, but nothing on the user end AFAIK.

Another solution would be to set skipLibCheck in TS configs, and I think we should do that in the whole repo, but that's another discussion.

This fix was already made to the 7.0.24 release branch, this just copies that fix.

What I did

How to test

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@JReinhold JReinhold added the maintenance User-facing maintenance tasks label Jun 27, 2023
@JReinhold JReinhold self-assigned this Jun 27, 2023
@JReinhold JReinhold added dependencies and removed maintenance User-facing maintenance tasks labels Jun 27, 2023
@JReinhold JReinhold added patch:yes Bugfix & documentation PR that need to be picked to main branch and removed patch:yes Bugfix & documentation PR that need to be picked to main branch labels Jul 6, 2023
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Why didn't we make this change on next first and patch it back, which is the typical workflow?

@JReinhold
Copy link
Contributor Author

Why didn't we make this change on next first and patch it back, which is the typical workflow?

@shilman this was a fix we did during the 7.0.24 release to unblock it, where we had to fix an S1 during the team meetup and it was all a bit chaotic, so we did the fix directly in the versioning branch.

@JReinhold JReinhold merged commit fb5d056 into next Jul 12, 2023
56 of 59 checks passed
@JReinhold JReinhold deleted the bump-svelte-vite-dep branch July 12, 2023 08:14
@github-actions github-actions bot mentioned this pull request Jul 12, 2023
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants