Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: Fix inconsistent stories in nextjs example #23422

Merged
merged 2 commits into from
Jul 12, 2023

Conversation

yannbf
Copy link
Member

@yannbf yannbf commented Jul 12, 2023

Closes #

What I did

A few stories for Nextjs were inconsistent in Chromatic, so this PR fixes them by:

  • skipping snapshotting for the blurred images, as there's a timing issues which may cause inconsistencies
  • waiting for images to be loaded before taking a snapshot in other stories

How to test

Chromatic will test for us!

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@yannbf yannbf added build Internal-facing build tooling & test updates ci:daily Run the CI jobs that normally run in the daily job. patch:yes Bugfix & documentation PR that need to be picked to main branch labels Jul 12, 2023
@yannbf yannbf force-pushed the fix/nextjs-inconsistent-snapshots branch from 6bc5492 to 34683a3 Compare July 12, 2023 09:18
@ndelangen ndelangen merged commit f76b060 into next Jul 12, 2023
15 checks passed
@ndelangen ndelangen deleted the fix/nextjs-inconsistent-snapshots branch July 12, 2023 12:59
@github-actions github-actions bot mentioned this pull request Jul 12, 2023
15 tasks
storybook-bot pushed a commit that referenced this pull request Jul 12, 2023
…apshots

Build: Fix inconsistent stories in nextjs example
(cherry picked from commit f76b060)
@github-actions github-actions bot mentioned this pull request Jul 12, 2023
16 tasks
storybook-bot pushed a commit that referenced this pull request Jul 13, 2023
…apshots

Build: Fix inconsistent stories in nextjs example
(cherry picked from commit f76b060)
storybook-bot pushed a commit that referenced this pull request Jul 13, 2023
…apshots

Build: Fix inconsistent stories in nextjs example
(cherry picked from commit f76b060)
storybook-bot pushed a commit that referenced this pull request Jul 13, 2023
…apshots

Build: Fix inconsistent stories in nextjs example
(cherry picked from commit f76b060)
storybook-bot pushed a commit that referenced this pull request Jul 13, 2023
…apshots

Build: Fix inconsistent stories in nextjs example
(cherry picked from commit f76b060)
storybook-bot pushed a commit that referenced this pull request Jul 13, 2023
…apshots

Build: Fix inconsistent stories in nextjs example
(cherry picked from commit f76b060)
storybook-bot pushed a commit that referenced this pull request Jul 13, 2023
…apshots

Build: Fix inconsistent stories in nextjs example
(cherry picked from commit f76b060)
storybook-bot pushed a commit that referenced this pull request Jul 13, 2023
…apshots

Build: Fix inconsistent stories in nextjs example
(cherry picked from commit f76b060)
storybook-bot pushed a commit that referenced this pull request Jul 14, 2023
…apshots

Build: Fix inconsistent stories in nextjs example
(cherry picked from commit f76b060)
storybook-bot pushed a commit that referenced this pull request Jul 14, 2023
…apshots

Build: Fix inconsistent stories in nextjs example
(cherry picked from commit f76b060)
storybook-bot pushed a commit that referenced this pull request Jul 15, 2023
…apshots

Build: Fix inconsistent stories in nextjs example
(cherry picked from commit f76b060)
storybook-bot pushed a commit that referenced this pull request Jul 15, 2023
…apshots

Build: Fix inconsistent stories in nextjs example
(cherry picked from commit f76b060)
storybook-bot pushed a commit that referenced this pull request Jul 17, 2023
…apshots

Build: Fix inconsistent stories in nextjs example
(cherry picked from commit f76b060)
storybook-bot pushed a commit that referenced this pull request Jul 17, 2023
…apshots

Build: Fix inconsistent stories in nextjs example
(cherry picked from commit f76b060)
storybook-bot pushed a commit that referenced this pull request Jul 17, 2023
…apshots

Build: Fix inconsistent stories in nextjs example
(cherry picked from commit f76b060)
storybook-bot pushed a commit that referenced this pull request Jul 17, 2023
…apshots

Build: Fix inconsistent stories in nextjs example
(cherry picked from commit f76b060)
storybook-bot pushed a commit that referenced this pull request Jul 17, 2023
…apshots

Build: Fix inconsistent stories in nextjs example
(cherry picked from commit f76b060)
storybook-bot pushed a commit that referenced this pull request Jul 17, 2023
…apshots

Build: Fix inconsistent stories in nextjs example
(cherry picked from commit f76b060)
storybook-bot pushed a commit that referenced this pull request Jul 18, 2023
…apshots

Build: Fix inconsistent stories in nextjs example
(cherry picked from commit f76b060)
@JReinhold JReinhold added the patch:done Patch/release PRs already cherry-picked to main/release branch label Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Internal-facing build tooling & test updates ci:daily Run the CI jobs that normally run in the daily job. patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants