-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build: Fix inconsistent stories in nextjs example #23422
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yannbf
added
build
Internal-facing build tooling & test updates
ci:daily
Run the CI jobs that normally run in the daily job.
patch:yes
Bugfix & documentation PR that need to be picked to main branch
labels
Jul 12, 2023
yannbf
force-pushed
the
fix/nextjs-inconsistent-snapshots
branch
from
July 12, 2023 09:18
6bc5492
to
34683a3
Compare
ndelangen
approved these changes
Jul 12, 2023
15 tasks
storybook-bot
pushed a commit
that referenced
this pull request
Jul 12, 2023
…apshots Build: Fix inconsistent stories in nextjs example (cherry picked from commit f76b060)
Closed
16 tasks
storybook-bot
pushed a commit
that referenced
this pull request
Jul 13, 2023
…apshots Build: Fix inconsistent stories in nextjs example (cherry picked from commit f76b060)
storybook-bot
pushed a commit
that referenced
this pull request
Jul 13, 2023
…apshots Build: Fix inconsistent stories in nextjs example (cherry picked from commit f76b060)
storybook-bot
pushed a commit
that referenced
this pull request
Jul 13, 2023
…apshots Build: Fix inconsistent stories in nextjs example (cherry picked from commit f76b060)
storybook-bot
pushed a commit
that referenced
this pull request
Jul 13, 2023
…apshots Build: Fix inconsistent stories in nextjs example (cherry picked from commit f76b060)
storybook-bot
pushed a commit
that referenced
this pull request
Jul 13, 2023
…apshots Build: Fix inconsistent stories in nextjs example (cherry picked from commit f76b060)
storybook-bot
pushed a commit
that referenced
this pull request
Jul 13, 2023
…apshots Build: Fix inconsistent stories in nextjs example (cherry picked from commit f76b060)
storybook-bot
pushed a commit
that referenced
this pull request
Jul 13, 2023
…apshots Build: Fix inconsistent stories in nextjs example (cherry picked from commit f76b060)
storybook-bot
pushed a commit
that referenced
this pull request
Jul 14, 2023
…apshots Build: Fix inconsistent stories in nextjs example (cherry picked from commit f76b060)
storybook-bot
pushed a commit
that referenced
this pull request
Jul 14, 2023
…apshots Build: Fix inconsistent stories in nextjs example (cherry picked from commit f76b060)
storybook-bot
pushed a commit
that referenced
this pull request
Jul 15, 2023
…apshots Build: Fix inconsistent stories in nextjs example (cherry picked from commit f76b060)
storybook-bot
pushed a commit
that referenced
this pull request
Jul 15, 2023
…apshots Build: Fix inconsistent stories in nextjs example (cherry picked from commit f76b060)
storybook-bot
pushed a commit
that referenced
this pull request
Jul 17, 2023
…apshots Build: Fix inconsistent stories in nextjs example (cherry picked from commit f76b060)
storybook-bot
pushed a commit
that referenced
this pull request
Jul 17, 2023
…apshots Build: Fix inconsistent stories in nextjs example (cherry picked from commit f76b060)
storybook-bot
pushed a commit
that referenced
this pull request
Jul 17, 2023
…apshots Build: Fix inconsistent stories in nextjs example (cherry picked from commit f76b060)
storybook-bot
pushed a commit
that referenced
this pull request
Jul 17, 2023
…apshots Build: Fix inconsistent stories in nextjs example (cherry picked from commit f76b060)
storybook-bot
pushed a commit
that referenced
this pull request
Jul 17, 2023
…apshots Build: Fix inconsistent stories in nextjs example (cherry picked from commit f76b060)
storybook-bot
pushed a commit
that referenced
this pull request
Jul 17, 2023
…apshots Build: Fix inconsistent stories in nextjs example (cherry picked from commit f76b060)
storybook-bot
pushed a commit
that referenced
this pull request
Jul 18, 2023
…apshots Build: Fix inconsistent stories in nextjs example (cherry picked from commit f76b060)
JReinhold
added
the
patch:done
Patch/release PRs already cherry-picked to main/release branch
label
Jul 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
build
Internal-facing build tooling & test updates
ci:daily
Run the CI jobs that normally run in the daily job.
patch:done
Patch/release PRs already cherry-picked to main/release branch
patch:yes
Bugfix & documentation PR that need to be picked to main branch
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #
What I did
A few stories for Nextjs were inconsistent in Chromatic, so this PR fixes them by:
How to test
Chromatic will test for us!
Checklist
MIGRATION.MD
Maintainers
make sure to add the
ci:merged
orci:daily
GH label to it.["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]