docs: replace unsupported value 'string' in controls #23565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joaonunomota
requested review from
yannbf,
ndelangen,
tmeasday,
kylegach and
jonniebigodes
as code owners
jonniebigodes
approved these changes
Jul 24, 2023
There was a problem hiding this comment.
@joaonunomota appreciate the time you took to put together this pull request and update the documentation and tests 🙏 ! From my end, documentation-wise, it's all good my end, I'll defer to the remainder maintainers for their input, and hopefully, we'll get this merged soon.
Hope you have a great week
Stay safe
ndelangen
approved these changes
Jul 25, 2023
ndelangen
added
the
patch:yes
27 tasks
storybook-bot
pushed a commit
that referenced
this pull request
Jul 25, 2023
docs: replace unsupported value 'string' in controls (cherry picked from commit 630ace1)
Closed
33 tasks
storybook-bot
pushed a commit
that referenced
this pull request
Jul 25, 2023
docs: replace unsupported value 'string' in controls (cherry picked from commit 630ace1)
storybook-bot
pushed a commit
that referenced
this pull request
Jul 25, 2023
docs: replace unsupported value 'string' in controls (cherry picked from commit 630ace1)
storybook-bot
pushed a commit
that referenced
this pull request
Jul 25, 2023
docs: replace unsupported value 'string' in controls (cherry picked from commit 630ace1)
storybook-bot
pushed a commit
that referenced
this pull request
Jul 25, 2023
docs: replace unsupported value 'string' in controls (cherry picked from commit 630ace1)
storybook-bot
pushed a commit
that referenced
this pull request
Jul 26, 2023
docs: replace unsupported value 'string' in controls (cherry picked from commit 630ace1)
30 tasks
storybook-bot
pushed a commit
that referenced
this pull request
Jul 26, 2023
docs: replace unsupported value 'string' in controls (cherry picked from commit 630ace1)
storybook-bot
pushed a commit
that referenced
this pull request
Jul 26, 2023
docs: replace unsupported value 'string' in controls (cherry picked from commit 630ace1)
storybook-bot
pushed a commit
that referenced
this pull request
Jul 26, 2023
docs: replace unsupported value 'string' in controls (cherry picked from commit 630ace1)
storybook-bot
pushed a commit
that referenced
this pull request
Jul 26, 2023
docs: replace unsupported value 'string' in controls (cherry picked from commit 630ace1)
storybook-bot
pushed a commit
that referenced
this pull request
Jul 27, 2023
docs: replace unsupported value 'string' in controls (cherry picked from commit 630ace1)
storybook-bot
pushed a commit
that referenced
this pull request
Jul 27, 2023
docs: replace unsupported value 'string' in controls (cherry picked from commit 630ace1)
storybook-bot
pushed a commit
that referenced
this pull request
Jul 27, 2023
docs: replace unsupported value 'string' in controls (cherry picked from commit 630ace1)
storybook-bot
pushed a commit
that referenced
this pull request
Jul 28, 2023
docs: replace unsupported value 'string' in controls (cherry picked from commit 630ace1)
storybook-bot
pushed a commit
that referenced
this pull request
Jul 28, 2023
docs: replace unsupported value 'string' in controls (cherry picked from commit 630ace1)
storybook-bot
pushed a commit
that referenced
this pull request
Jul 28, 2023
docs: replace unsupported value 'string' in controls (cherry picked from commit 630ace1)
storybook-bot
pushed a commit
that referenced
this pull request
Jul 31, 2023
docs: replace unsupported value 'string' in controls (cherry picked from commit 630ace1)
storybook-bot
pushed a commit
that referenced
this pull request
Jul 31, 2023
docs: replace unsupported value 'string' in controls (cherry picked from commit 630ace1)
storybook-bot
pushed a commit
that referenced
this pull request
Aug 1, 2023
docs: replace unsupported value 'string' in controls (cherry picked from commit 630ace1)
storybook-bot
pushed a commit
that referenced
this pull request
Aug 1, 2023
docs: replace unsupported value 'string' in controls (cherry picked from commit 630ace1)
storybook-bot
pushed a commit
that referenced
this pull request
Aug 1, 2023
docs: replace unsupported value 'string' in controls (cherry picked from commit 630ace1)
storybook-bot
pushed a commit
that referenced
this pull request
Aug 1, 2023
docs: replace unsupported value 'string' in controls (cherry picked from commit 630ace1)
storybook-bot
pushed a commit
that referenced
this pull request
Aug 1, 2023
docs: replace unsupported value 'string' in controls (cherry picked from commit 630ace1)
storybook-bot
pushed a commit
that referenced
this pull request
Aug 2, 2023
docs: replace unsupported value 'string' in controls (cherry picked from commit 630ace1)
storybook-bot
pushed a commit
that referenced
this pull request
Aug 2, 2023
docs: replace unsupported value 'string' in controls (cherry picked from commit 630ace1)
storybook-bot
pushed a commit
that referenced
this pull request
Aug 2, 2023
docs: replace unsupported value 'string' in controls (cherry picked from commit 630ace1)
storybook-bot
pushed a commit
that referenced
this pull request
Aug 2, 2023
docs: replace unsupported value 'string' in controls (cherry picked from commit 630ace1)
storybook-bot
pushed a commit
that referenced
this pull request
Aug 3, 2023
docs: replace unsupported value 'string' in controls (cherry picked from commit 630ace1)
Closed
32 tasks
storybook-bot
pushed a commit
that referenced
this pull request
Aug 4, 2023
docs: replace unsupported value 'string' in controls (cherry picked from commit 630ace1)
storybook-bot
pushed a commit
that referenced
this pull request
Aug 7, 2023
docs: replace unsupported value 'string' in controls (cherry picked from commit 630ace1)
storybook-bot
pushed a commit
that referenced
this pull request
Aug 7, 2023
docs: replace unsupported value 'string' in controls (cherry picked from commit 630ace1)
storybook-bot
pushed a commit
that referenced
this pull request
Aug 7, 2023
docs: replace unsupported value 'string' in controls (cherry picked from commit 630ace1)
storybook-bot
pushed a commit
that referenced
this pull request
Aug 7, 2023
docs: replace unsupported value 'string' in controls (cherry picked from commit 630ace1)
storybook-bot
pushed a commit
that referenced
this pull request
Aug 8, 2023
docs: replace unsupported value 'string' in controls (cherry picked from commit 630ace1)
storybook-bot
pushed a commit
that referenced
this pull request
Aug 9, 2023
docs: replace unsupported value 'string' in controls (cherry picked from commit 630ace1)
storybook-bot
pushed a commit
that referenced
this pull request
Aug 9, 2023
docs: replace unsupported value 'string' in controls (cherry picked from commit 630ace1)
storybook-bot
pushed a commit
that referenced
this pull request
Aug 9, 2023
docs: replace unsupported value 'string' in controls (cherry picked from commit 630ace1)
kasperpeulen
removed
the
patch:yes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
stringas the control type in docs withtext, sincestringis not an accepted value.control: 'string'in a test to avoid confusion, the test passes after updating the input and expected output.Checklist
MIGRATION.MD
Maintainers
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.ts["cleanup", "BREAKING CHANGE", "feature request", "bug", "build", "documentation", "maintenance", "dependencies", "other"]