Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addon-essentials: Pull addon-themes from essentials #23652

Merged
merged 4 commits into from
Jul 31, 2023

Conversation

ShaunEvening
Copy link
Contributor

@ShaunEvening ShaunEvening commented Jul 28, 2023

What I did

  • Remove addon-themes from essentials until we're ready to migrate users from addon-styling

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "build", "documentation", "maintenance", "dependencies", "other"]

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

@ShaunEvening ShaunEvening added cleanup Minor cleanup style change that won't show up in release changelog theming patch:no labels Jul 28, 2023
@ShaunEvening ShaunEvening self-assigned this Jul 28, 2023
@yannbf yannbf added the ci:merged Run the CI jobs that normally run when merged. label Jul 28, 2023
Copy link
Member

@yannbf yannbf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@jonniebigodes jonniebigodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@integrayshaun, thanks for taking the time to make the required updates. Appreciate it 🙏 ! I'm good with it.

@ndelangen ndelangen self-assigned this Jul 31, 2023
@ndelangen ndelangen removed their assignment Jul 31, 2023
@ShaunEvening ShaunEvening merged commit fb1895f into next Jul 31, 2023
15 checks passed
@ShaunEvening ShaunEvening deleted the pull-themes-from-essentials branch July 31, 2023 13:07
@github-actions github-actions bot mentioned this pull request Jul 31, 2023
16 tasks
@kasperpeulen kasperpeulen changed the title Pull addon-themes from essentials Addon-essentials: Pull addon-themes from essentials Jul 31, 2023
@vanessayuenn vanessayuenn added maintenance User-facing maintenance tasks and removed cleanup Minor cleanup style change that won't show up in release changelog labels Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:merged Run the CI jobs that normally run when merged. maintenance User-facing maintenance tasks theming
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants