Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API: Remove stories.json support #25236

Merged
merged 1 commit into from
Dec 18, 2023
Merged

API: Remove stories.json support #25236

merged 1 commit into from
Dec 18, 2023

Conversation

shilman
Copy link
Member

@shilman shilman commented Dec 15, 2023

Closes N/A

What I did

Remove legacy v6 formats. Note that the manager can still compose v6 storybooks. But v6 storybooks will not be able to compose v8 storybooks (v7 storybooks probably could though).

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

  • Build a storybook and validate that stories.json is no longer generated

Documentation

  • Update MIGRATION.md

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

Copy link
Contributor

github-actions bot commented Dec 15, 2023

Fails
🚫 PR is marked with "BREAKING CHANGE" label.

Generated by 🚫 dangerJS against ff88e04

@shilman
Copy link
Member Author

shilman commented Dec 18, 2023

Discussed with @tmeasday and we're OK with this more aggressive approach. @thafryer we'll need to make sure that Chromatic is updated to skip creating a stories.json file when it detects SB8 and above, otherwise we'll create one every time.

@shilman shilman merged commit 152edae into next Dec 18, 2023
57 of 59 checks passed
@shilman shilman deleted the shilman/kill-stories-json branch December 18, 2023 07:03
@github-actions github-actions bot mentioned this pull request Dec 19, 2023
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants