Core: Unique outputDir/cacheDir for each configDir #25264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndelangen
requested review from
kasperpeulen,
JReinhold,
tmeasday,
shilman,
yannbf,
valentinpalkovic and
IanVS
as code owners
ndelangen
changed the title
shilman
requested changes
Dec 21, 2023
| const targetPath = path.join(outputDir, targetDir); | ||
| logger.info(chalk`=> Copying static files: {cyan ${staticDir}} => {cyan ${targetDir}}`); | ||
| const targetPath = join(outputDir, targetDir); | ||
| if (!staticDir.includes('node_modules')) { |
There was a problem hiding this comment.
This line could use a comment explaining why
| chalk`=> Copying static files: {cyan ${print(from)}} at {cyan ${print(targetPath)}}` | ||
| ); | ||
| } | ||
| // logger.info(chalk`=> Copying static files: {cyan ${from}} at {cyan ${targetPath}}`); |
There was a problem hiding this comment.
Suggested change
| // logger.info(chalk`=> Copying static files: {cyan ${from}} at {cyan ${targetPath}}`); |
shilman
approved these changes
Dec 21, 2023
shilman
changed the title
12 tasks
|
Will this be patched in V7 as well? |
|
@domneo Nope. Please upgrade to the latest prerelease to use it. We're expecting a stable release in early 2024: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #24082
I think this will also fix this issue: #21510
What I did
I ensured that storybook when using a cache directory as an output directory, will use a unique sub-dir per storybook configDir.
I also cleaned up a bit of terminal output, there were absolute paths in there, which feels noisy.
It also printed out a message about copying over things from node_modules, which I doubt is useful information to the user, as it was storybook's internal pre-bundled stuff that was getting copied)
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
Making a static build of any storybook, and check if it work.
Provide a manual outputDir via a CLI flag and see if it works
Start a dev sandbox
check the
node_modules/.cachedirectory. It's contents should include:The long hash is unique per storybook configDir. It does not leak anything personally identifiable.
Here's the code creating it:
storybook/code/lib/core-server/src/build-dev.ts
Line 60 in 3b94da1
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>