-
-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to UglifyJS that supports ES6 and up #2530
Conversation
I changed base to |
@ggarek Amazing you want to pick this up, thank you so much! I would love to merge this as soon as possible. I do think we need to adjust this not just for react and react-native, but also for Vue and Angular. |
# Conflicts: # app/react-native/src/server/config/webpack.config.prod.js # app/react/src/server/config/webpack.config.prod.js # yarn.lock
merged in master after the 3.3 merge (saved you the plain of the merge conflicts) and added the code to angular & vue |
Codecov Report
@@ Coverage Diff @@
## master #2530 +/- ##
==========================================
- Coverage 32.69% 32.68% -0.01%
==========================================
Files 398 398
Lines 8837 8838 +1
Branches 947 934 -13
==========================================
Hits 2889 2889
- Misses 5298 5333 +35
+ Partials 650 616 -34
Continue to review full report at Codecov.
|
Anyone from @storybooks/team want to review and possibly merge? |
Issue:
What I did
Use
uglify-es
throughuglifyjs-webpack-plugin
to be able to minify es6+ code.I stumbled upon same issue, then found this PR, which was not very active recently. So i submit this PR in continuation to original one.
How to test
I tested as proposed in the original PR. Here are some screenshots.
Build time (is ~28s)
![screen shot 2017-12-22 at 16 04 26](https://user-images.githubusercontent.com/5501062/34289024-d3e79532-e733-11e7-9338-30e1eafc7c14.png)
Bundle size
Note
I have no opportunity to check IE 😭