Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vue3: Fix SourceDecorator Exception #25773

Merged
merged 8 commits into from
Feb 23, 2024
Merged

Conversation

chakAs3
Copy link
Contributor

@chakAs3 chakAs3 commented Jan 27, 2024

Closes #25523

What I did

i passed a basic decodeEntities to baseParse, it became required in latest versions of Vue

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

@chakAs3 chakAs3 changed the title Bump version from "8.0.0-alpha.14" to "8.0.0-alpha.15" [skip ci] Vue3:fix baseParse exception Jan 27, 2024
@chakAs3 chakAs3 added ci:daily Run the CI jobs that normally run in the daily job. bug labels Jan 27, 2024
@chakAs3 chakAs3 changed the title Vue3:fix baseParse exception Vue3: Fix baseParse Exception Jan 27, 2024
@chakAs3 chakAs3 changed the title Vue3: Fix baseParse Exception Vue3: Fix SourceDecorator Exception Jan 27, 2024
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we test this? Is the change backwards compatible with older versions of Vue3?

@chakAs3
Copy link
Contributor Author

chakAs3 commented Jan 29, 2024

Can we test this? Is the change backwards compatible with older versions of Vue3?

we can only test it visually cause it is a source snippet, this worked with the older version, with latest version is throwing an exception in runtime only, the source viewer not showing the expected source.

decodeEntities was optional in older versions so i don't think will break

@Saurabhmagicsw
Copy link

hello all, please review and merge, I need this fix

Copy link
Contributor

@kasperpeulen kasperpeulen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MisterIsaak
Copy link

@chakAs3 @kasperpeulen , any chance this can get merged? Looks like it's good to go unless there's discussions/concerns elsewhere.

@chakAs3
Copy link
Contributor Author

chakAs3 commented Feb 22, 2024

@chakAs3 @kasperpeulen , any chance this can get merged? Looks like it's good to go unless there's discussions/concerns elsewhere.

No discussion it is straightforward. waiting for updated status

@kasperpeulen kasperpeulen merged commit 639e83a into next Feb 23, 2024
105 checks passed
@kasperpeulen kasperpeulen deleted the chaks/fix-baseParse-catch branch February 23, 2024 08:41
@kasperpeulen
Copy link
Contributor

Merged!

@github-actions github-actions bot mentioned this pull request Feb 23, 2024
16 tasks
@YUN-RU-TSENG
Copy link

I still have same issue error Error: [@vue/compiler-core] decodeEntities option is required in browser builds. , I install storybook today, should i update version? my storybook version is

"@storybook/addon-essentials": "^7.6.17",
"@storybook/addon-interactions": "^7.6.17",
"@storybook/addon-links": "^7.6.17",
"@storybook/blocks": "^7.6.17",
"@storybook/test": "^7.6.17",
"@storybook/vue3": "^7.6.17",
"@storybook/vue3-vite": "^7.6.17",

@kasperpeulen
Copy link
Contributor

It is only fixed in 8.0 @YUN-RU-TSENG

@YUN-RU-TSENG
Copy link

thanks, i will update to 8.0 @kasperpeulen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug ci:daily Run the CI jobs that normally run in the daily job. vue3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: decodeEntities option is required in browser builds
7 participants