Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addon-actions: Add spy to action for explicit actions #26033

Merged
merged 8 commits into from
Feb 15, 2024

Conversation

kasperpeulen
Copy link
Contributor

@kasperpeulen kasperpeulen commented Feb 14, 2024

Closes #25810

What I did

We accidently also removed spies for explicit actions, allthough that was never the plan. This reverts that (and also improves on the old implementation)

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

馃 Canary release

This pull request has been released as version 0.0.0-pr-26033-sha-fe0448b1. Try it out in a new sandbox by running npx storybook@0.0.0-pr-26033-sha-fe0448b1 sandbox or in an existing project with npx storybook@0.0.0-pr-26033-sha-fe0448b1 upgrade.

More information
Published version 0.0.0-pr-26033-sha-fe0448b1
Triggered by @kasperpeulen
Repository storybookjs/storybook
Branch kasper/spy-on-explicit-actions
Commit fe0448b1
Datetime Thu Feb 15 14:02:55 UTC 2024 (1708005775)
Workflow run 7917111050

To request a new release of this pull request, mention the @storybookjs/core team.

core team members can create a new canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=26033

@kasperpeulen kasperpeulen changed the title Actions: Do add spy to action for explicit actions Actions: Add spy to action for explicit actions Feb 15, 2024
@kasperpeulen kasperpeulen merged commit be84a02 into next Feb 15, 2024
53 of 59 checks passed
@kasperpeulen kasperpeulen deleted the kasper/spy-on-explicit-actions branch February 15, 2024 19:28
@github-actions github-actions bot mentioned this pull request Feb 15, 2024
13 tasks
@shilman shilman changed the title Actions: Add spy to action for explicit actions Addon-actions: Add spy to action for explicit actions Feb 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: [Fundtion handler] is not a spy or a call to a spy
1 participant