Build: Upgrade esbuild (0.20.1)
#26255
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -52,7 +52,7 @@ | |
| "@yarnpkg/libzip": "2.3.0", | ||
| "chalk": "^4.1.0", | ||
| "cross-spawn": "^7.0.3", | ||
| "esbuild": "^18.0.0 || ^19.0.0 || ^0.20.0", | ||
|
There was a problem hiding this comment. Typo?
There was a problem hiding this comment. it is a typo! 👀 this was added by @ndelangen i think, probably trying to account for mixed versions in dependency trees. should be easy enough to fix at least There was a problem hiding this comment. @ndelangen already takes care of it: #26405 |
||
| "esbuild-register": "^3.5.0", | ||
| "execa": "^5.0.0", | ||
| "file-system-cache": "2.3.0", | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@valentinpalkovic do you remember why we are on 0.18? I reckon something happened in the past but I just don't remember
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I honestly have no clue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
whats the best way to prove everything is fine other than CI being happy?
if you can point me in the right direction, i can try do further testing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We upgraded it last 9 months ago.
#21727
It might just have been a hiccup with mixed versions.
This LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm,.. maybe this:
#26112