Build: Upgrade esbuild (0.20.1)
#26255
Conversation
| @@ -52,7 +52,7 @@ | |||
| "@yarnpkg/esbuild-plugin-pnp": "^3.0.0-rc.10", | |||
| "browser-assert": "^1.2.1", | |||
| "ejs": "^3.1.8", | |||
| "esbuild": "^0.18.0", | |||
There was a problem hiding this comment.
@valentinpalkovic do you remember why we are on 0.18? I reckon something happened in the past but I just don't remember
There was a problem hiding this comment.
I honestly have no clue.
There was a problem hiding this comment.
whats the best way to prove everything is fine other than CI being happy?
if you can point me in the right direction, i can try do further testing
There was a problem hiding this comment.
We upgraded it last 9 months ago.
It might just have been a hiccup with mixed versions.
This LGTM
ndelangen
changed the title
esbuild (0.20.1)
| @@ -52,7 +52,7 @@ | |||
| "@yarnpkg/libzip": "2.3.0", | |||
| "chalk": "^4.1.0", | |||
| "cross-spawn": "^7.0.3", | |||
| "esbuild": "^0.18.0", | |||
| "esbuild": "^18.0.0 || ^19.0.0 || ^0.20.0", | |||
There was a problem hiding this comment.
Typo?
18.0.0 -> 0.18.0
19.0.0 -> 0.19.0
There was a problem hiding this comment.
it is a typo! 👀 this was added by @ndelangen i think, probably trying to account for mixed versions in dependency trees. should be easy enough to fix at least
There was a problem hiding this comment.
@ndelangen already takes care of it: #26405
Thanks for letting us know!
This just upgrades esbuild to 0.20.1
Do you have any concerns with doing this?
The reason (other than staying up to date) is that many other peers are now on 0.20.x, so storybook's various packages are resulting in our dependency tree have many copies of esbuild instead of a single de-duped copy.