CLI: Fix vite config automigration to resolve from project root #26262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mandarini Could you check out the canary release of this PR? |
valentinpalkovic
force-pushed
the
valentin/fix-vite-config-automigration
branch
from
f1bafcb
to
9492cb4
Compare
valentinpalkovic
changed the title
valentinpalkovic
force-pushed
the
valentin/fix-vite-config-automigration
branch
from
9492cb4
to
bb8590c
Compare
kasperpeulen
reviewed
Mar 4, 2024
Comment on lines
+42
to
+56
| type PromptType<ResultType = any, T = Prompt> = | ||
| | T | ||
| | ((result: ResultType) => Promise<Prompt> | Prompt); | ||
|
|
||
| export type Fix<ResultType = any> = ( | ||
| | { | ||
| promptType?: PromptType<ResultType, 'auto'>; | ||
| run: (options: RunOptions<ResultType>) => Promise<void>; | ||
| } | ||
| | { | ||
| promptType: PromptType<ResultType, 'manual' | 'notification'>; | ||
| run?: never; | ||
| } | ||
| ) & | ||
| BaseFix<ResultType>; |
kasperpeulen
approved these changes
Mar 4, 2024
17 tasks
shilman
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #26260
What I did
I try to resolve and search for the vite.config.js starting from the project root instead of
cwdduring thevite-config-fileautomigration.Additionally, the
vite-config-fileautomigrations throws an error instead of showing a prompt. This was because thepromptTypewasn't defined and arunfunction was missing. I have improved the types for theFixtype.Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.馃 Canary release
This pull request has been released as version
0.0.0-pr-26262-sha-bb8590c9. Try it out in a new sandbox by runningnpx storybook@0.0.0-pr-26262-sha-bb8590c9 sandboxor in an existing project withnpx storybook@0.0.0-pr-26262-sha-bb8590c9 upgrade.More information
0.0.0-pr-26262-sha-bb8590c9valentin/fix-vite-config-automigrationbb8590c91709537407)To request a new release of this pull request, mention the
@storybookjs/coreteam.core team members can create a new canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=26262