Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Onboarding: Fix manager dist reference #26282

Merged
merged 1 commit into from Mar 2, 2024

Conversation

shilman
Copy link
Member

@shilman shilman commented Mar 2, 2024

Closes #26280

What I did

Fix the reference to dist/manager.js which must have gotten messed up when we brought the addon into the SB monorepo

How to test

Create an empty project with the following structure in .storybook/main.ts:

import { dirname, join } from "path";

const getAbsolutePath = <I extends string>(input: I): I =>
  dirname(require.resolve(join(input, "package.json"))) as any;

const config: StorybookConfig = {
  addons: [
    getAbsolutePath("@storybook/addon-onboarding"),
    getAbsolutePath("@storybook/addon-links"),
    getAbsolutePath("@storybook/addon-essentials"),
    getAbsolutePath("@chromatic-com/storybook"),
    getAbsolutePath("@storybook/addon-interactions"),
  ],
  framework: {
    name: getAbsolutePath("@storybook/react-vite"),
    ///...
  • Verify that the RC crashes
  • Verify that the Canary starts successfully

馃 Canary release

This pull request has been released as version 0.0.0-pr-26282-sha-c3335f7d. Try it out in a new sandbox by running npx storybook@0.0.0-pr-26282-sha-c3335f7d sandbox or in an existing project with npx storybook@0.0.0-pr-26282-sha-c3335f7d upgrade.

More information
Published version 0.0.0-pr-26282-sha-c3335f7d
Triggered by @shilman
Repository storybookjs/storybook
Branch shilman/26280-fix-onboarding-manager
Commit c3335f7d
Datetime Sat Mar 2 00:28:20 UTC 2024 (1709339300)
Workflow run 8118889431

To request a new release of this pull request, mention the @storybookjs/core team.

core team members can create a new canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=26282

@shilman
Copy link
Member Author

shilman commented Mar 2, 2024

Self-merging @storybookjs/core

@shilman shilman merged commit 64be727 into next Mar 2, 2024
57 of 65 checks passed
@shilman shilman deleted the shilman/26280-fix-onboarding-manager branch March 2, 2024 00:51
@github-actions github-actions bot mentioned this pull request Mar 2, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: RC0 fails to run storybook with addon-onboarding
1 participant