Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: Add event when serverChannel disconnects #26322

Merged
merged 4 commits into from Mar 5, 2024

Conversation

ndelangen
Copy link
Member

Closes: #25937

What I did

  • I added a new core event: CHANNEL_WS_DISCONNECT = 'channelWSDisconnect'
  • This event is triggered when the serverChannel is disconnected
  • I added tests for the WebsocketTransport

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

I manually checked it using a sandbox and a dummy manager.ts, see:

websocket-disconnect-event.mov

Documentation

This new event/functionality is undocumented right now, but so are all the other events...

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

@ndelangen ndelangen marked this pull request as ready for review March 5, 2024 13:58
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work @ndelangen 👏

@shilman shilman changed the title Core: Channel add event when serverChannel disconnect Core: Add event when serverChannel disconnects Mar 5, 2024
@shilman shilman merged commit 85c4d9c into next Mar 5, 2024
57 checks passed
@shilman shilman deleted the norbert/ws-disconnect-event branch March 5, 2024 17:25
@github-actions github-actions bot mentioned this pull request Mar 5, 2024
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: No notification on dev server exit
2 participants