Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: Fix preloading too early #26442

Merged
merged 3 commits into from Mar 20, 2024
Merged

Core: Fix preloading too early #26442

merged 3 commits into from Mar 20, 2024

Conversation

ndelangen
Copy link
Member

@ndelangen ndelangen commented Mar 12, 2024

What I did

This should stop this error for appearing:

Uncaught (in promise) SB_PREVIEW_API_0005 (CalledPreviewMethodBeforeInitializationError): Called `Preview.onPreloadStories()` before initialization.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

  • Start a sandbox in dev-mode
  • Have it open the browser
  • Close the dev server (keep browser open)
  • Restart the dev-server, and quickly:
    • Hover over a different component in the sidebar
    • refresh the browser (multiple times until the manager UI shows up)

Before this change you could encounter the error listed above.

This should no longer happen after this change.

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

@ndelangen ndelangen changed the title Core: Preloadingremove the error being thrown when preloading too early Core: Preloading too early fixed Mar 12, 2024
@ndelangen ndelangen self-assigned this Mar 12, 2024
@ndelangen ndelangen requested a review from yannbf March 12, 2024 12:33
Copy link

nx-cloud bot commented Mar 12, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit f770091. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@ndelangen ndelangen marked this pull request as ready for review March 12, 2024 12:44
Copy link
Member

@yannbf yannbf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Did not test

@ndelangen ndelangen merged commit 90a992e into next Mar 20, 2024
55 checks passed
@ndelangen ndelangen deleted the norbert/preloading-error-fix branch March 20, 2024 12:12
@github-actions github-actions bot mentioned this pull request Mar 20, 2024
11 tasks
@shilman shilman changed the title Core: Preloading too early fixed Core: Fix preloading too early Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants