Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Portable Stories: Remove link to missing docs #27075

Merged
merged 1 commit into from
May 9, 2024
Merged

Portable Stories: Remove link to missing docs #27075

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions code/lib/preview-api/src/modules/store/csf/portable-stories.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -292,8 +292,7 @@ describe('composeStory', () => {
`
"Some stories were not cleaned up before rendering 'Unnamed Story (firstArg, secondArg)'.

You should load the story with \`await Story.load()\` before rendering it.
See https://storybook.js.org/docs/api/portable-stories-vitest#3-load for more information."
You should load the story with \`await Story.load()\` before rendering it."
`
);
});
Expand Down
7 changes: 3 additions & 4 deletions code/lib/preview-api/src/modules/store/csf/portable-stories.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,11 +142,10 @@ export function composeStory<TRenderer extends Renderer = Renderer, TArgs extend
console.warn(
dedent`Some stories were not cleaned up before rendering '${humanReadableIdentifier}'.

You should load the story with \`await Story.load()\` before rendering it.
See https://storybook.js.org/docs/api/portable-stories-${
process.env.JEST_WORKER_ID !== undefined ? 'jest' : 'vitest'
}#3-load for more information.`
You should load the story with \`await Story.load()\` before rendering it.`
);
// TODO: Add a link to the docs when they are ready
// eg. "See https://storybook.js.org/docs/api/portable-stories-${process.env.JEST_WORKER_ID !== undefined ? 'jest' : 'vitest'}#3-load for more information."
}
return story.unboundStoryFn(prepareContext(context));
},
Expand Down
Loading