Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Fix sidebar doesn't wrap issue #27234

Open
wants to merge 1 commit into
base: next
Choose a base branch
from

Conversation

H0onnn
Copy link

@H0onnn H0onnn commented May 23, 2024

Closes #27206

What I did

I found where the problem occurred. (Please refer to screenshot)

스크린샷 2024-05-23 오전 9 57 09

The issue is caused by the "display: 'table'" property. When I changed this to "display: block", I was able to confirm that the problem was solved without interfering with the existing CSS.

But I can't find that div element within storybook project. Perhaps this element is an internal element of the ScrollAreaPrimitive provided by radix-ui.

So to access that element I used a CSS selector and changed the element to "display: block".

const ScrollAreaRoot = styled(ScrollAreaPrimitive.Root)<{ scrollbarsize: number; offset: number }>(
  ({ scrollbarsize, offset }) => ({
    width: '100%',
    height: '100%',
    overflow: 'hidden',
    '--scrollbar-size': `${scrollbarsize + offset}px`,
    '--radix-scroll-area-thumb-width': `${scrollbarsize}px`,
    '& > div:nth-child(1) > div:nth-child(1)': {  // add this line
      display: 'block',
    },
  })
);

I hope this will solve the problem. If you have a better solution, please comment. thank you

2024-05-23.10.07.19.mov

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

I don't think a separate test is needed.

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

@shilman shilman changed the title [Fix] fix sidebar doesn't wrap issue UI: Fix sidebar doesn't wrap issue May 25, 2024
@shilman shilman requested a review from cdedreuille May 25, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Sidebar doesn't wrap which hides the "Run tests" and "Settings" buttons
3 participants