Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added instructions for adding JSON loader #274

Closed
wants to merge 1 commit into from
Closed

Added instructions for adding JSON loader #274

wants to merge 1 commit into from

Conversation

ffxsam
Copy link

@ffxsam ffxsam commented Jun 23, 2016

Storybook was yielding errors out of the box. These steps are critical IMO

Storybook was yielding errors out of the box. These steps are critical IMO
@arunoda
Copy link
Member

arunoda commented Jun 23, 2016

I like this, how about introducing json-loader by default. We already disucss this on #261 here. But kind a stop doing this for other workaround.

What do you think?

@ffxsam
Copy link
Author

ffxsam commented Jun 23, 2016

If it makes Storybook work out of the box, then I'm all for including it in the package! Ideally, for best developer experience, it should work after installing without extra work on the dev's part.

@arunoda
Copy link
Member

arunoda commented Jun 23, 2016

Yeah agree. We will bring back #261

@arunoda
Copy link
Member

arunoda commented Aug 15, 2016

Closing since, now we've json-loader in 2.x

@arunoda arunoda closed this Aug 15, 2016
@shilman shilman added the misc label May 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants