Tags: Fix unsafe project-level tags lookup #27511
Merged
+18
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shilman
added
bug
patch:yes
shilman
changed the title
☁️ Nx Cloud ReportCI is running/has finished running commands for commit f993f25. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 2 targetsSent with 💌 from NxCloud. |
valentinpalkovic
approved these changes
Jun 2, 2024
shilman
changed the title
storybook-bot
pushed a commit
that referenced
this pull request
Jun 2, 2024
…-tags Tags: Fix unsafe project-level tags lookup (cherry picked from commit 341904e)
This was referenced Jun 2, 2024
Merged
storybook-bot
pushed a commit
that referenced
this pull request
Jun 2, 2024
…-tags Tags: Fix unsafe project-level tags lookup (cherry picked from commit 341904e)
storybook-bot
pushed a commit
that referenced
this pull request
Jun 2, 2024
…-tags Tags: Fix unsafe project-level tags lookup (cherry picked from commit 341904e)
storybook-bot
pushed a commit
that referenced
this pull request
Jun 3, 2024
…-tags Tags: Fix unsafe project-level tags lookup (cherry picked from commit 341904e)
storybook-bot
pushed a commit
that referenced
this pull request
Jun 3, 2024
…-tags Tags: Fix unsafe project-level tags lookup (cherry picked from commit 341904e)
storybook-bot
pushed a commit
that referenced
this pull request
Jun 4, 2024
…-tags Tags: Fix unsafe project-level tags lookup (cherry picked from commit 341904e)
storybook-bot
pushed a commit
that referenced
this pull request
Jun 5, 2024
…-tags Tags: Fix unsafe project-level tags lookup (cherry picked from commit 341904e)
storybook-bot
pushed a commit
that referenced
this pull request
Jun 5, 2024
…-tags Tags: Fix unsafe project-level tags lookup (cherry picked from commit 341904e)
storybook-bot
pushed a commit
that referenced
this pull request
Jun 5, 2024
…-tags Tags: Fix unsafe project-level tags lookup (cherry picked from commit 341904e)
github-actions
bot
added
the
patch:done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #27510
What I did
Catch preview.js parsing errors and present a warning instead of crashing
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
Create a preview that has tags that can't be parsed:
🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>