-
-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLI: Fix typo in React Docgen migration #27536
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 0683575. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
kylegach
approved these changes
Jun 4, 2024
storybook-bot
pushed a commit
that referenced
this pull request
Jun 9, 2024
CLI: Fix typo in React Docgen migration (cherry picked from commit f7b7225)
This was referenced Jun 9, 2024
Merged
storybook-bot
pushed a commit
that referenced
this pull request
Jun 9, 2024
CLI: Fix typo in React Docgen migration (cherry picked from commit f7b7225)
storybook-bot
pushed a commit
that referenced
this pull request
Jun 10, 2024
CLI: Fix typo in React Docgen migration (cherry picked from commit f7b7225)
storybook-bot
pushed a commit
that referenced
this pull request
Jun 10, 2024
CLI: Fix typo in React Docgen migration (cherry picked from commit f7b7225)
storybook-bot
pushed a commit
that referenced
this pull request
Jun 10, 2024
CLI: Fix typo in React Docgen migration (cherry picked from commit f7b7225)
storybook-bot
pushed a commit
that referenced
this pull request
Jun 10, 2024
CLI: Fix typo in React Docgen migration (cherry picked from commit f7b7225)
storybook-bot
pushed a commit
that referenced
this pull request
Jun 10, 2024
CLI: Fix typo in React Docgen migration (cherry picked from commit f7b7225)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
automigrations
ci:normal
cli
maintenance
User-facing maintenance tasks
patch:done
Patch/release PRs already cherry-picked to main/release branch
patch:yes
Bugfix & documentation PR that need to be picked to main branch
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this small pull request, the React Docgen migration was fixed to avoid us introducing a typo in the package name (i.e.,
react-docgen-typescript
), as demonstrated in the screenshot below when a user runs the upgrade workflow.I left the
patch:yes
label so that this can be ported over to the main branch and hopefully fixed in a future release. Feel free to remove it if not intended.What I did
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal
,ci:merged
orci:daily
GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.ts
Make sure this PR contains one of the labels below:
Available labels
bug
: Internal changes that fixes incorrect behavior.maintenance
: User-facing maintenance tasks.dependencies
: Upgrading (sometimes downgrading) dependencies.build
: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup
: Minor cleanup style change. Will not show up in release changelog.documentation
: Documentation only changes. Will not show up in release changelog.feature request
: Introducing a new feature.BREAKING CHANGE
: Changes that break compatibility in some way with current major version.other
: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/core
team here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>