-
-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release: Prerelease 8.2.0-alpha.11 #28319
base: next-release
Are you sure you want to change the base?
Release: Prerelease 8.2.0-alpha.11 #28319
Conversation
bb51259
to
a5e80df
Compare
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 18f096d. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 2 targetsSent with 💌 from NxCloud. |
a5e80df
to
c2588ee
Compare
c2588ee
to
f939cd4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
(updates since last review)
/code/core/src/core-server/withTelemetry.ts
: Removed NODE_ENV 'test' check for crash report prompts in CI environments./code/package.json
: AddeddeferredNextVersion
field set to8.2.0-alpha.11
./docs/versions/next.json
: Updated to reflect version8.2.0-alpha.11
with detailed changelog.
3 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
Angular: Enhance Error Handling and Entry Normalization
0377e01
to
cfd2f7e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
(updates since last review)
/code/frameworks/angular/src/server/plugins/storybook-normalize-angular-entry-plugin.js
: Improved handling of Webpack entry points for Angular projects; merged 'main' and 'styles' entries; added error logging./code/package.json
: AddeddeferredNextVersion
property set to8.2.0-alpha.11
./docs/versions/next.json
: Updated to reflect version8.2.0-alpha.11
with a detailed changelog.
No major changes found since last review.
3 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
Addon Interactions: Use unique keys when rendering array nodes in panel
Blocks: Fix reference to storybook core
cfd2f7e
to
bf1aa31
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
(updates since last review)
/code/addons/interactions/src/components/MethodCall.tsx
: Modified key generation forNode
component to include index and stringified value./code/lib/blocks/src/blocks/Source.tsx
: Updated import paths to reference internal modules./code/package.json
: AddeddeferredNextVersion
field for version bump to8.2.0-alpha.11
./docs/versions/next.json
: Updated to reflect new version8.2.0-alpha.11
with changelog.
4 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
bf1aa31
to
4df4bf1
Compare
Core: Add support for `beforeAll` hook
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
(updates since last review)
- Removed
node-fetch
import from multiple files (/scripts/release/utils/github-client.ts
,/scripts/release/utils/get-github-info.ts
,/scripts/release/publish.ts
,/scripts/release/is-version-published.ts
,/scripts/event-log-checker.ts
,/scripts/sandbox/utils/git.ts
,/scripts/utils/githubClient.ts
) - Updated
/code/package.json
to includedeferredNextVersion
field for version bump to8.2.0-alpha.11
- Simplified code examples in
/docs/_snippets/loader-story.md
and/docs/_snippets/storybook-preview-global-loader.md
by removingnode-fetch
- Updated
/docs/versions/next.json
to reflect new version8.2.0-alpha.11
with detailed changelog - Removed
@types/node-fetch
andnode-fetch
dependencies from/scripts/package.json
12 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
4df4bf1
to
0b5df9c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
(updates since last review)
- Added
beforeAll
hook in/code/core/src/preview-api/modules/preview-web/Preview.tsx
- Introduced
composeBeforeAllHooks
in/code/core/src/preview-api/modules/store/csf/beforeAll.ts
- Added tests for
beforeAll
in/code/core/src/preview-api/modules/store/csf/beforeAll.test.ts
- Updated
composeConfigs
to includebeforeAll
in/code/core/src/preview-api/modules/store/csf/composeConfigs.ts
- Enhanced type safety in
setProjectAnnotations
across multiple files (/code/frameworks/nextjs/src/portable-stories.ts
,/code/renderers/react/src/portable-stories.tsx
,/code/renderers/svelte/src/portable-stories.ts
,/code/renderers/vue3/src/portable-stories.ts
)
17 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings
return async () => { | ||
const cleanups: CleanupCallback[] = []; | ||
for (const hook of hooks) { | ||
const cleanup = await hook(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧠 logic: Check if hook
returns a cleanup function before adding it to the cleanups
array.
…-target SWC: Set default targets for swc that align with our esbuild targets
0b5df9c
to
d0c21fe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
(updates since last review)
- Updated
code/package.json
withdeferredNextVersion
set to8.2.0-alpha.11
- Updated
docs/versions/next.json
to reflect version8.2.0-alpha.11
- Changelog updates: unique keys for rendering array nodes in Addon Interactions panel
- Added new icons for Addon Onboarding splash screen
- Several Angular-specific improvements
2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
…dme-update Build: Opencollective update sponsors links
d0c21fe
to
068dd74
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
(updates since last review)
- Updated sponsor section in
/README.md
with individual avatars and links - Added
deferredNextVersion
field in/code/package.json
- Updated version and changelog in
/docs/versions/next.json
3 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
068dd74
to
e6d2a30
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
3 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
This is an automated pull request that bumps the version from
8.2.0-alpha.10
to8.2.0-alpha.11
.Once this pull request is merged, it will trigger a new release of version
8.2.0-alpha.11
.If you're not a core maintainer with permissions to release you can ignore this pull request.
To do
Before merging the PR, there are a few QA steps to go through:
And for each change below:
This is a list of all the PRs merged and commits pushed directly to
next
, that will be part of this release:beforeAll
hook #28255mount
in react, svelte, and vue renderers #28385env.bugfixes
in SWC so destructuring is never transpiled #28363read-pkg-up
tofd-package-json
#28272pkg-dir
tofd-package-json
#28270f9474c0c7dc9adf73ba638b5fed283df2e5ab575
d21d317c51f898ca60c75f9b7c7bfed67201c451
memoizerific
and remove need forutil-deprecate
#28410packageManager
field #28405yarn
everywhere #28286If you've made any changes doing the above QA (change PR titles, revert PRs), manually trigger a re-generation of this PR with this workflow and wait for it to finish. It will wipe your progress in this to do, which is expected.
Feel free to manually commit any changes necessary to this branch after you've done the last re-generation, following the Make Manual Changes section in the docs, especially if you're making changes to the changelog.
When everything above is done:
Generated changelog
8.2.0-alpha.11
beforeAll
hook - #28255, thanks @ghengeveld!pkg-dir
tofd-package-json
- #28270, thanks @43081j!read-pkg-up
tofd-package-json
- #28272, thanks @43081j!env.bugfixes
in SWC so destructuring is never transpiled - #28363, thanks @kasperpeulen!mount
in react, svelte, and vue renderers - #28385, thanks @kasperpeulen!Greptile Summary
deferredNextVersion
field with value8.2.0-alpha.11
.8.2.0-alpha.11
with a summary of changes.