Don't try to access the devtools hook if we are cross-origin

[tmeasday]

This throws an exception and kills storybook in non-standard cases (like Chromatic's live mode). cc @ndelangen -- I think you saw this.

[Hypnosphi]

We do a similar thing in Vue, it probably needs the check as well

[ndelangen]

@Hypnosphi can you explain the chromatic diff? Seems like your handywork no? 😀

[Hypnosphi]

Sure it is, but I have no idea why chromatic doesn't allow to approve it

[tmeasday]

Yeah it looks like the master build/commit that this branched off (https://www.chromaticqa.com/build?appId=5a375b97f4b14f0020b0cda3&number=2309) included that change and was never approved.

The reason we can't approve the build for this PR comes down to the fact Chromatic's branch detection has been messed up by the change to TeamCity. Hopefully #3477 will resolve that.

I'll add the Vue check on this PR and rebase off current master, hopefully that'll sort out the chromatic thing.

[codecov]

Codecov Report

Merging #3485 into master will decrease coverage by <.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #3485      +/-   ##
==========================================
- Coverage   37.41%   37.41%   -0.01%     
==========================================
  Files         455      455              
  Lines       10294    10297       +3     
  Branches      945      930      -15     
==========================================
+ Hits         3852     3853       +1     
- Misses       5861     5869       +8     
+ Partials      581      575       -6

Impacted Files	Coverage Δ
app/react/src/server/config/globals.js	0% <0%> (ø)	⬆️
lib/core/src/server/build-dev.js	20% <0%> (-0.16%)	⬇️
addons/storyshots/src/vue/renderTree.js	60% <0%> (ø)	⬆️
lib/components/src/table/table.js	83.33% <0%> (ø)	⬆️
addons/info/src/components/markdown/code.js	76.92% <0%> (ø)	⬆️
lib/ui/src/modules/ui/configs/handle_routing.js	24.21% <0%> (ø)	⬆️
.../ui/src/modules/ui/components/layout/dimensions.js	21.87% <0%> (ø)	⬆️
lib/ui/src/modules/ui/routes.js	0% <0%> (ø)	⬆️
lib/ui/src/modules/api/index.js	0% <0%> (ø)	⬆️
lib/ui/src/modules/ui/components/layout/usplit.js	38.7% <0%> (ø)	⬆️
... and 64 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 18f6521...279d4f9. Read the comment docs.

[tmeasday]

Any idea what's happening with these Image stories in chromatic? This build is based on https://www.chromaticqa.com/build?appId=5a375b97f4b14f0020b0cda3&number=2341 where all stories were approved and does of course not change those stories

[tmeasday]

Happy to merge this and fix the Chromatic problems separately of course.

[tmeasday]

Note I accidentally pushed 8984572 to release/3.4 to do the same thing there. I intended to make another PR.

I can't force push to remove it from history, I'm inclined to just leave it, LMK if that's bad @storybooks/team team

[Hypnosphi]

Any idea what's happening with these Image stories in chromatic?

Oh, that's probably because the images are random, we need to replace them with static placeholders

[tmeasday]

Or we can just ignore then in Chromatic if it is too hard to do that

[tmeasday]

But yeah, using https://placehold.it or the like is probably fine?

[Hypnosphi]

Sure