Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change WithNotes to withNotes in using-addons docs #3530

Merged
merged 1 commit into from
May 4, 2018

Conversation

zgreen
Copy link
Contributor

@zgreen zgreen commented May 4, 2018

Issue: an example in the using-addons docs throws a withNotes is not defined error, because of a capitalization error.

What I did

Fixed a docs capitalization typo.

@Hypnosphi Hypnosphi added documentation patch:yes Bugfix & documentation PR that need to be picked to main branch labels May 4, 2018
@codecov
Copy link

codecov bot commented May 4, 2018

Codecov Report

Merging #3530 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3530   +/-   ##
=======================================
  Coverage   37.61%   37.61%           
=======================================
  Files         459      459           
  Lines       10377    10377           
  Branches      928      930    +2     
=======================================
  Hits         3903     3903           
+ Misses       5932     5896   -36     
- Partials      542      578   +36
Impacted Files Coverage Δ
...-native/src/preview/components/OnDeviceUI/index.js 0% <0%> (ø) ⬆️
app/react-native/src/bin/storybook.js 0% <0%> (ø) ⬆️
lib/ui/src/modules/shortcuts/actions/shortcuts.js 18.84% <0%> (ø) ⬆️
addons/knobs/src/mithril/WrapStory.js 0% <0%> (ø) ⬆️
lib/ui/src/modules/ui/libs/hierarchy.js 49.03% <0%> (ø) ⬆️
lib/core/src/client/preview/reducer.js 37.5% <0%> (ø) ⬆️
...ons/actions/src/lib/types/object/configureDepth.js 62.5% <0%> (ø) ⬆️
...react-native/src/manager/components/PreviewHelp.js 0% <0%> (ø) ⬆️
lib/ui/src/modules/api/configs/init_api.js 40.42% <0%> (ø) ⬆️
lib/ui/src/libs/withLifecycleDecorator.js 18.91% <0%> (ø) ⬆️
... and 58 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3539625...409c10a. Read the comment docs.

@Hypnosphi Hypnosphi merged commit daebde6 into storybookjs:master May 4, 2018
@Hypnosphi Hypnosphi added the patch:done Patch/release PRs already cherry-picked to main/release branch label May 5, 2018
Hypnosphi added a commit that referenced this pull request May 5, 2018
Change WithNotes to withNotes in using-addons docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants