Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

forgot the link to riot #4618

Merged
merged 1 commit into from Oct 29, 2018
Merged

forgot the link to riot #4618

merged 1 commit into from Oct 29, 2018

Conversation

libetl
Copy link
Member

@libetl libetl commented Oct 29, 2018

oops, I forgot one link in the docs

@libetl
forgot the link to riot
46bea57 
oops, I forgot one link
@libetl libetl self-assigned this Oct 29, 2018
@libetl libetl added documentation cleanup Minor cleanup style change that won't show up in release changelog patch:yes Bugfix & documentation PR that need to be picked to main branch app: riot and removed cleanup Minor cleanup style change that won't show up in release changelog labels Oct 29, 2018
@codecov
Copy link

codecov bot commented Oct 29, 2018 •
edited

Codecov Report

Merging #4618 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4618   +/-   ##
=======================================
  Coverage   35.59%   35.59%           
=======================================
  Files         557      557           
  Lines        6732     6732           
  Branches      884      884           
=======================================
  Hits         2396     2396           
  Misses       3876     3876           
  Partials      460      460

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1de2180...46bea57. Read the comment docs.

@gabrielcsapo gabrielcsapo self-requested a review October 29, 2018 22:24
@gabrielcsapo gabrielcsapo merged commit 78b7a68 into master Oct 29, 2018
@gabrielcsapo gabrielcsapo deleted the libetl-patch-1 branch October 29, 2018 22:24
shilman pushed a commit that referenced this pull request Oct 31, 2018
@gabrielcsapo @shilman
Merge pull request #4618 from storybooks/libetl-patch-1
6f8b195 
forgot the link to riot
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Oct 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabrielcsapo gabrielcsapo gabrielcsapo approved these changes

@Hypnosphi Hypnosphi Awaiting requested review from Hypnosphi

@ndelangen ndelangen Awaiting requested review from ndelangen ndelangen is a code owner

@shilman shilman Awaiting requested review from shilman shilman is a code owner

Assignees

@libetl libetl

Labels
documentation patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@libetl @gabrielcsapo @shilman