Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete sfc_vue fixture to fix master #4666

Closed
wants to merge 1 commit into from
Closed

Conversation

igor-dv
Copy link
Member

@igor-dv igor-dv commented Oct 31, 2018

Issue:

Master is red because of the old vue fixture that already does not work with the new sb@cli version.
Any new vue cli tests are welcomed.

@igor-dv igor-dv added maintenance User-facing maintenance tasks cli labels Oct 31, 2018
@igor-dv igor-dv self-assigned this Oct 31, 2018
@codecov
Copy link

codecov bot commented Oct 31, 2018

Codecov Report

Merging #4666 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4666   +/-   ##
=======================================
  Coverage   35.59%   35.59%           
=======================================
  Files         557      557           
  Lines        6732     6732           
  Branches      884      884           
=======================================
  Hits         2396     2396           
  Misses       3876     3876           
  Partials      460      460

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69fc051...74d2d78. Read the comment docs.

@Hypnosphi
Copy link
Member

Hypnosphi commented Oct 31, 2018

Did we intentionally break that usecase?

We can just remove all the tests and make master green forever

@Hypnosphi
Copy link
Member

OK here's another plan:

I'll add teamcity reporting to CLI test, so that each fixture will be reported as a testcase. Then I'll mute this fixture on teamcity until we actually find out what went wrong

@igor-dv
Copy link
Member Author

igor-dv commented Oct 31, 2018

Definitely, agree with you, removing this is not a real solution. I feel that vue needs a bit more maintenance love.
Anyway, having this failing is confusing other PRs. The deletion could be alway reverted when anyone will invest some time in solving the real problem.
But controlling this from CI is much better 👍

@igor-dv igor-dv closed this Oct 31, 2018
@Hypnosphi
Copy link
Member

#4671

@ndelangen ndelangen deleted the try-to-fix-master branch May 7, 2019 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli maintenance User-facing maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants