-
-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revise the sample in README for ReactNative #4780
Conversation
With this change, the sample works without any errors.
With this change, the sample works without any warnings.
Codecov Report
@@ Coverage Diff @@
## master #4780 +/- ##
=======================================
Coverage 35.48% 35.48%
=======================================
Files 557 557
Lines 6747 6747
Branches 892 892
=======================================
Hits 2394 2394
Misses 3887 3887
Partials 466 466 Continue to review full report at Codecov.
|
Generated by 🚫 dangerJS |
Hey, thanks for the PR. I think somebody has fixed this already before, but it is missing. Let's hope it won't disappear anymore. |
@Gongreg please label PRs when you merge -- we have danger set up to block the merge for a reason 😘 |
Oh, saw you commented on this and assumed it has everything already. My bad, my bad |
It is merged to master btw... |
Revise the sample in README for ReactNative
With this change, the sample works without any errors.
What I did
Before change the code of entry point(App.js), I ran into follwing error:
After change it, I ran into following error:
Then I have added the line to
storybook/stories/index.js
, it works without errors.EDIT: I add a commit describe below:
I also ran into a warning that described at #4680, So fixing it same way.