Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TypeScript CRA example #5011

Closed
wants to merge 7 commits into from

Conversation

mucsi96
Copy link

@mucsi96 mucsi96 commented Dec 16, 2018

Issue:

What I did

I have created an example incorporating CRA2, TypeScript, TSLint, Jest, Enzyme

image

Closes #5006

@mucsi96 mucsi96 mentioned this pull request Dec 16, 2018
@shilman shilman added maintenance User-facing maintenance tasks typescript labels Dec 18, 2018
@mucsi96
Copy link
Author

mucsi96 commented Dec 18, 2018

@shilman Can you help me with broken build? Looks like its totally not related to the changes I have made. Would be very helpful to move this forward

@ndelangen ndelangen changed the base branch from master to next December 19, 2018 10:09
@ndelangen ndelangen self-assigned this Dec 19, 2018
@codecov
Copy link

codecov bot commented Dec 19, 2018

Codecov Report

Merging #5011 into next will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             next    #5011   +/-   ##
=======================================
  Coverage   34.85%   34.85%           
=======================================
  Files         579      579           
  Lines        7038     7038           
  Branches      943      943           
=======================================
  Hits         2453     2453           
  Misses       4082     4082           
  Partials      503      503

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5b4e89...326d87d. Read the comment docs.

@igor-dv
Copy link
Member

igor-dv commented Dec 19, 2018

This PR is containing changes from wrong commits (probably needs a merge from next).
IMO we don't need this as an example app, considering maintenance cost. Better having it as a CLI test. If this more like having a working example, it can also be done out of the monorepo..

@mucsi96
Copy link
Author

mucsi96 commented Dec 20, 2018

I can see that storybook itself is migrating over TypeScript. Its a very popular setup. Because of that I thought it makes sence to have a similar example setup as well. It looks easy now but I spent half a day to make it working as it required quite a bit of investigation. IMO if this is out of monorepo less people will find it. Right now there is quite long documentation related to TypeScript. Maybe we can just point to this example? What do you think?

@igor-dv
Copy link
Member

igor-dv commented Dec 29, 2018

@mucsi96, mind solve the conflicts + fix the linter?

@mucsi96
Copy link
Author

mucsi96 commented Dec 29, 2018

@igor-dv Sure! Will create a new PR from scratch based on next branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance User-facing maintenance tasks typescript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CRA2 TypeScript example
5 participants