Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: move react-select dependency to 2.2 #5867

Merged
merged 2 commits into from Mar 5, 2019
Merged

fix: move react-select dependency to 2.2 #5867

merged 2 commits into from Mar 5, 2019

Conversation

SimenB
Copy link
Contributor

@SimenB SimenB commented Mar 5, 2019

Issue:

Version 2.3 went from emotion 10 to emotion 9, causing issues with code dedupe for us (since yarn decided to hoist differently).

2.3 is still en semver range here, but this allows us to lock down the older version.

We're stuck on alpha.5 due to the upgrade that landed in alpha 6

See JedWatson/react-select#3346

What I did

Lowered the version in package.json.

An alternative plan is to not use a lib that's larger than react-dom just to render a dropdown in an addon 馃槢

How to test

Not much to test

Version 2.3 went from emotion 10 to emotion 9, causing issues with code dedupe for us (since yarn decided to hoist differently).

2.3 is still en semver range here, but this allows us to lock down the older version
@vercel
Copy link

vercel bot commented Mar 5, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

@vercel vercel bot requested a deployment to staging March 5, 2019 08:34 Abandoned
@vercel
Copy link

vercel bot commented Mar 5, 2019

Deployment failed with the following error:

Builds rate limit exceeded (0 of 100 remaining). Try again in 24h

@vercel vercel bot requested a deployment to staging March 5, 2019 08:47 Abandoned
@vercel
Copy link

vercel bot commented Mar 5, 2019

Deployment failed with the following error:

Builds rate limit exceeded (0 of 100 remaining). Try again in 24h

@codecov
Copy link

codecov bot commented Mar 5, 2019

Codecov Report

Merging #5867 into next will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             next    #5867   +/-   ##
=======================================
  Coverage   35.01%   35.01%           
=======================================
  Files         648      648           
  Lines        9480     9480           
  Branches     1360     1333   -27     
=======================================
  Hits         3319     3319           
  Misses       5532     5532           
  Partials      629      629

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 3176058...d49697b. Read the comment docs.

@ndelangen
Copy link
Member

An alternative plan is to not use a lib that's larger than react-dom just to render a dropdown in an addon

Yeah you're right, this package is huge, I noticed this too when debugging.

Would love to switch to something lighter!

@ndelangen
Copy link
Member

If this frees up your upgrade path, I'm ok with having a lower version of this package for a while!

@ndelangen ndelangen merged commit 578a52e into storybookjs:next Mar 5, 2019
@SimenB SimenB deleted the patch-3 branch March 5, 2019 10:17
@SimenB
Copy link
Contributor Author

SimenB commented Mar 5, 2019

Thank you!

@SimenB
Copy link
Contributor Author

SimenB commented Mar 5, 2019

Would love to switch to something lighter!

I haven't tested it, but maybe https://ui.reach.tech/menu-button could do the trick for you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants