Use webpack chunkhash to enable long-term caching #597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. This makes sense. |
This was referenced Jan 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #372
Use chunkhash in the output filenames to enable long-term caching.
Note: This was originally #594 but was closed. I updated it and am re-opening. @arunoda you mentioned that caching already exists via #578, however given that this project is already using webpack I'd think it's better to use the built-in webpack caching feature vs the "old way" of appending a random cachebuster.
This PR also fixes a bug with some assets were not being included in the
iframe.html. My compiled CSS was never being output, I think it may have something to do with the fact that I'm using the ExtractTextPlugin which automatically hashes my CSS file usingchunkhash. After this PR, mypreview.cssis output into theiframe.html.NOTE: This bugfix wouldn't be possible with the cachekey method since you need to parse webpack's output to get the hashed filename.