馃洃yarn prepare errors in the logs #6415
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
libetl
added
maintenance
|
This pull request is automatically deployed with Now. |
libetl
commented
Apr 4, 2019
| @@ -15,10 +15,10 @@ function getCommand(watch) { | |||
| return `${tsc} ${args.join(' ')}`; | |||
| } | |||
|
|
|||
| function handleExit(code, errorCallback) { | |||
| function handleExit(code, stderr, errorCallback) { | |||
There was a problem hiding this comment.
this one will be gone after the @babel/preset-typescript migration.
ndelangen
approved these changes
Apr 4, 2019
kroeder
added a commit
that referenced
this pull request
Apr 4, 2019
|
This PR can be closed. I've added your changes to the babel-typescript branch - thanks for giving me a ping for your change 馃憤 |
|
Perfect |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
What I did
when
yarn prepareis failing, we only see 'FAILED'. Sometimes we are just merging next in our branch and we are unaware of what can have caused the compilation error.So I propose to display the babel errors in the logs
How to test
Just modify a source and inject a compilation error, then run
yarn prepareon the project.If your answer is yes to any of these, please make sure to include it in your PR.