Migrate @storybook/angular to typescript #6570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically deployed with Now. Latest deployment for this branch: https://monorepo-git-ts-migration-app-angular.storybook.now.sh |
tsc wants all imports to be under rootDir
igor-dv
reviewed
May 1, 2019
| @@ -1,5 +1,5 @@ | |||
| import { getAngularCliWebpackConfigOptions } from './angular-cli_config'; | |||
| import angularJson from '../../../../examples/angular-cli/angular.json'; | |||
| import { getAngularCliWebpackConfigOptions } from '../angular-cli_config'; | |||
There was a problem hiding this comment.
just checking what is happening around, do we have some new convention to put tests in the __tests dir ?
There was a problem hiding this comment.
We don't. I just wanted to bring some order in the server directory.
Is it worth to caring about this? I don't know. I can leave it as is 🙂
There was a problem hiding this comment.
I like colocation of tests, until the folder gets like 6+ files, then having a tests folder is kinda nice. I don't care enough about it either way really. 👍
ndelangen
reviewed
Jun 11, 2019
ndelangen
approved these changes
Jun 11, 2019
ndelangen
force-pushed
the
ts-migration/app-angular
branch
from
e28b3bd
to
6a37e95
Compare
ndelangen
force-pushed
the
ts-migration/app-angular
branch
from
6a37e95
to
e079c89
Compare
# Conflicts: # app/angular/src/client/preview/index.js # scripts/compile-babel.js # yarn.lock
ndelangen
force-pushed
the
ts-migration/app-angular
branch
from
e079c89
to
997ce27
Compare
ndelangen
force-pushed
the
ts-migration/app-angular
branch
from
195ff88
to
c87d5ae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #5030