Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add accessibility on searchbar react-native #6819

Merged
merged 1 commit into from
May 29, 2019
Merged

feat: add accessibility on searchbar react-native #6819

merged 1 commit into from
May 29, 2019

Conversation

wilau2
Copy link
Contributor

@wilau2 wilau2 commented May 18, 2019

Make it easier to navigate between stories with detox.
(When list of story get big it's easier to navigate using the filter searchbar)

@vercel
Copy link

vercel bot commented May 18, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://monorepo-git-fork-wilau2-feat-add-accessibility-on-5bd0b6.storybook.now.sh

@ndelangen
Copy link
Member

Thanks, what does testID do?

@wilau2
Copy link
Contributor Author

wilau2 commented May 20, 2019

@ndelangen
It's an attribute test ID, a lot of modern e2e test framework recommend having some to interact with your app.

It will normally keep your tests safe from css or js changes:
https://docs.cypress.io/guides/references/best-practices.html#Selecting-Elements

You can check in the very same file I modified, it was already present on list item elements:
https://github.com/storybooks/storybook/blob/ad8edd2d66515d171f78ceb7d9138efb15577f8f/app/react-native/src/preview/components/StoryListView/index.tsx#L58

@Gongreg
Copy link
Member

Gongreg commented May 27, 2019

@shilman, any reason we don't merge it? It is a non breaking change that can help for users using e2e tests with storybook.

@shilman
Copy link
Member

shilman commented May 28, 2019

@Gongreg We're in a feature freeze for shipping 5.1. Can merge non-bug changes if there's good reason, but otherwise this is a 5.2 feature

@Gongreg
Copy link
Member

Gongreg commented May 29, 2019

Got it @shilman. This one definitely doesn't break anything and helps people using detox or other e2e test tools. IMO we could silently add it to 5.1

Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok!

@shilman shilman merged commit b6d7798 into storybookjs:next May 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants