Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use same version of webpack in @storybook/core and @storybook/react #6997

Merged
merged 2 commits into from
Jun 12, 2019

Conversation

christophehurpeau
Copy link
Contributor

Issue:

What I did

Change the webpack version in @storybook/react to be the same as the one in @storybook/core

@vercel
Copy link

vercel bot commented Jun 6, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://monorepo-git-fork-christophehurpeau-patch-1.storybook.now.sh

@shilman shilman added dependencies patch:yes Bugfix & documentation PR that need to be picked to main branch labels Jun 6, 2019
@shilman shilman added this to the 5.1.x milestone Jun 6, 2019
@shilman
Copy link
Member

shilman commented Jun 6, 2019

Seems reasonable, but there are lots of webpack deps across different storybook packages and they all resolve to 4.32.2 (currently), so what exactly does it accomplish?

@christophehurpeau
Copy link
Contributor Author

We use create-react-app so react-scripts has its own webpack version lower than storybook. This is the one that's in the root node_modules, and both @storybook/core and @storybook/react have a webpack version in their node_modules, and they have different versions. That mean we have 3 webpack versions and it felt wrong.
We could update all dependencies with yarn upgrade to make sure all dependencies are to the latest possible version, but I'm guessing we're not the only ones in this case

@ndelangen ndelangen merged commit 013f168 into storybookjs:next Jun 12, 2019
@shilman shilman removed the patch:yes Bugfix & documentation PR that need to be picked to main branch label Jun 13, 2019
@christophehurpeau christophehurpeau deleted the patch-1 branch June 23, 2019 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants