Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

specifying where to get withInfo #7013

Merged
merged 1 commit into from Jun 9, 2019
Merged

specifying where to get withInfo #7013

merged 1 commit into from Jun 9, 2019

Conversation

jimmy-e
Copy link
Contributor

@jimmy-e jimmy-e commented Jun 9, 2019

Issue:

What I did

How to test

  • Is this testable with Jest or Chromatic screenshots?
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

@vercel
Copy link

vercel bot commented Jun 9, 2019 •
edited

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://monorepo-git-fork-jimmy-e-patch-3.storybook.now.sh

shilman
shilman approved these changes Jun 9, 2019
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks

@shilman shilman added addon: info documentation patch:yes Bugfix & documentation PR that need to be picked to main branch labels Jun 9, 2019
@shilman shilman added this to the 5.1.x milestone Jun 9, 2019
@shilman shilman merged commit f64cff0 into storybookjs:master Jun 9, 2019
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Jun 10, 2019
shilman added a commit that referenced this pull request Jun 10, 2019
@shilman
specifying where to get withInfo (#7013)
fed3db6 
specifying where to get `withInfo`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shilman shilman shilman approved these changes

@dangreenisrael dangreenisrael Awaiting requested review from dangreenisrael dangreenisrael is a code owner

@danielduan danielduan Awaiting requested review from danielduan

@theinterned theinterned Awaiting requested review from theinterned theinterned is a code owner

@usulpro usulpro Awaiting requested review from usulpro usulpro is a code owner

@z4o4z z4o4z Awaiting requested review from z4o4z z4o4z is a code owner

Assignees
No one assigned
Labels
addon: info documentation patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Milestone
5.1.x
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jimmy-e @shilman