Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tech/remove redundant storyshots #7112

Merged
merged 3 commits into from
Jun 18, 2019
Merged

Conversation

ndelangen
Copy link
Member

Issue: codebase is bloated with storyshots, that are also in chromatic

What I did

REMOVED the tests
REMOVED the storyshots

@ndelangen ndelangen added the maintenance User-facing maintenance tasks label Jun 17, 2019
@ndelangen ndelangen added this to the 5.2.0 milestone Jun 17, 2019
@ndelangen ndelangen requested a review from shilman June 17, 2019 14:45
@ndelangen ndelangen self-assigned this Jun 17, 2019
@vercel
Copy link

vercel bot commented Jun 17, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://monorepo-git-tech-remove-redudent-storyshots.storybook.now.sh

Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YAY!

@ndelangen ndelangen merged commit 5f8e9d0 into next Jun 18, 2019
@ndelangen ndelangen deleted the tech/remove-redudent-storyshots branch June 18, 2019 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance User-facing maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants