Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI: Use process.env.CI if available #7118

Merged
merged 1 commit into from
Jun 18, 2019
Merged

CLI: Use process.env.CI if available #7118

merged 1 commit into from
Jun 18, 2019

Conversation

shilman
Copy link
Member

@shilman shilman commented Jun 18, 2019

Issue: N/A

What I did

Respect process.env.CI as a substitute for --ci

How to test

cd examples/official-storybook
yarn storybook
yarn storybook --ci
CI=1 yarn storybook

@vercel
Copy link

vercel bot commented Jun 18, 2019 •
edited
Loading

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://monorepo-git-feature-respect-ci-env-var.storybook.now.sh

@shilman shilman added this to the 5.2.0 milestone Jun 18, 2019
tmeasday
tmeasday approved these changes Jun 18, 2019
View reviewed changes
Copy link
Member

@tmeasday tmeasday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, that was easier than I expected

@shilman shilman merged commit 6fec113 into next Jun 18, 2019
@shilman shilman deleted the feature/respect-ci-env-var branch June 18, 2019 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmeasday tmeasday tmeasday approved these changes

@ndelangen ndelangen ndelangen approved these changes

@alterx alterx Awaiting requested review from alterx

@igor-dv igor-dv Awaiting requested review from igor-dv

Assignees
No one assigned
Labels
cli feature request
Projects
None yet
Milestone
5.2.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@shilman @tmeasday @ndelangen