Addon-docs: Support non-story exports in MDX #7188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shilman
requested review from
alterx,
danielduan,
igor-dv,
ndelangen,
tmeasday and
usulpro
as code owners
|
This pull request is automatically deployed with Now. |
tmeasday
approved these changes
Jun 25, 2019
| if (parameters && parameters.expression) { | ||
| const { code: params } = generate(parameters.expression, {}); | ||
| parameters = `parameters: ${params},`; | ||
| parameters = params; |
There was a problem hiding this comment.
You can do this in one line with
({ code: parameters } = generate(parameters.expression, {}));For better or worse 🤷♂
ndelangen
approved these changes
Jun 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #6995
What I did
Update the MDX compiler to support the
includeStoriesmetadata introduced in #7185How to test
See the stories under
Addons > Docs > mdxwhich have non-story exports