Grammar/typo fixes in Readme #7584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically deployed with Now. Latest deployment for this branch: https://monorepo-git-fork-jimmydalecleveland-patch-2.storybook.now.sh |
wuweiweiwu
reviewed
Jul 27, 2019
| addons). If the active param were gone after story switching, it fallback to the default then the first. As a | ||
| rule of thumbs, whenever collisions made possible, always the first wins. | ||
| 5. Query parameters are supported for pre-selecting contexts param, which comes handy for visual regression testing. | ||
| addons). If the active params were gone after story switching, it falls back to the default then the first. As a |
| @@ -178,13 +178,13 @@ An array of params contains a set of predefined `props` for `components`. This o | |||
|
|
|||
| (required) | |||
|
|
|||
| An unique name for representing the props. | |||
| A unique name for representing the props. | |||
There was a problem hiding this comment.
not a grammar pro but shouldnt this stay An as unique starts with a vowel?
There was a problem hiding this comment.
It is a vowel, but the sound is what matters. A consonant sound, which unique makes here ("yun" with a hard y).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: Quite a few grammatical errors and typos that made the readme harder to parse
What I did
Fixed all the issues I saw