Jest add flexibility #7748
Merged
Jest add flexibility #7748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…used the theme throughout
|
This pull request is automatically deployed with Now. |
…st-add-flexibility # Conflicts: # addons/jest/src/components/Panel.tsx
CodeByAlex
requested review from
renaudtertrais,
shilman and
thomasbertet
as code owners
shilman
reviewed
Aug 13, 2019
addons/jest/src/components/Panel.tsx
Outdated
| const testsByType: Map<string, any> = new Map(); | ||
| result.assertionResults.forEach((assertion: any) => { | ||
| // using switch to allow for new types to be added | ||
| switch (assertion.status) { |
There was a problem hiding this comment.
why not just use assertion.status instead of switch because the logic is the same in each branch?
There was a problem hiding this comment.
Oh my goodness, nice find. I could definitely use assertion.status instead. No need for the switch at all
shilman
approved these changes
Aug 13, 2019
|
Also, what's the bug? |
|
@shilman switched it to maintenance. Do you think it would fall under that category? |
|
@CodeByAlex that was my thought 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Refactored the Jest code a bit from being an MVP to a more sustainable codebase. Built-in flexibility for adding new types of test status' that will help @fabiradi work on his bugfix/feature outlined here: #7740.
Sorted values coming into the status bar so that it will order the parts from smallest to largest
slightly improved performance by using fewer loops in render function
How to test
If your answer is yes to any of these, please make sure to include it in your PR.