Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change example repository with new CRA and Typesc… #8071

Merged
merged 1 commit into from Sep 30, 2019

Conversation

Luchanso
Copy link
Member

What I did

Change example repository with fresh dependencies

How to test

  • Clone example repository
  • Run following commands in repo:
yarn
yarn storybook
  • Check storybook work

@vercel
Copy link

vercel bot commented Sep 13, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://monorepo-git-fork-luchanso-next.storybook.now.sh

@shilman
Copy link
Member

shilman commented Sep 13, 2019

This looks great. Have you tried the typescript preset? https://www.npmjs.com/package/@storybook/preset-typescript

@shilman shilman added cra Prioritize create-react-app compatibility documentation typescript labels Sep 13, 2019
@Luchanso
Copy link
Member Author

@shilman nope, but I'll try tomorrow

@mrmckeb
Copy link
Member

mrmckeb commented Sep 27, 2019

Hi there, I think this should be handled by the new CRA preset, without a preset for TypeScript. How do we feel about that?

@shilman
Copy link
Member

shilman commented Sep 27, 2019

@mrmckeb that sounds right to me!

@ndelangen
Copy link
Member

@mrmckeb So we do not want to combine the typescript preset plus the cra preset.

That sounds right to me too.

How does that relate to this PR? Is this mergeable still, or should it be migrated to use the preset before merging?

@mrmckeb
Copy link
Member

mrmckeb commented Sep 30, 2019

We could merge this in now, I'll need to rewrite in the very near future when we do a non-beta release of the preset (which will also have docgen in it).

@shilman shilman added the patch:yes Bugfix & documentation PR that need to be picked to main branch label Sep 30, 2019
@shilman shilman merged commit 8e44132 into storybookjs:next Sep 30, 2019
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Oct 1, 2019
shilman added a commit that referenced this pull request Oct 1, 2019
Change example repository with new CRA and Typesc…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cra Prioritize create-react-app compatibility documentation patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch typescript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants