Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build: Upgrade chromatic #8246

Merged
merged 15 commits into from
Oct 3, 2019
Merged

Build: Upgrade chromatic #8246

merged 15 commits into from
Oct 3, 2019

Conversation

ndelangen
Copy link
Member

upgrade chromatic

@ndelangen ndelangen self-assigned this Oct 1, 2019
@vercel
Copy link

vercel bot commented Oct 1, 2019 •
edited
Loading

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://monorepo-git-tech-upgrade-chromatic.storybook.now.sh

@ndelangen ndelangen changed the title UPGRADe chromatic to test UPGRADE chromatic to test Oct 1, 2019
@shilman
Copy link
Member

shilman commented Oct 1, 2019

@ndelangen Do you know why the snapshots diffs are happening?

@ndelangen
Copy link
Member Author

No I do not...

@ndelangen
Copy link
Member Author

Before:
https://www.chromaticqa.com/component?appId=5a375b97f4b14f0020b0cda3&name=Addons%7CInfo%2FParameters&buildNumber=12007&specName=Using%20Parameters%20Across%20All%20Stories

After:
https://www.chromaticqa.com/component?appId=5a375b97f4b14f0020b0cda3&name=Addons%7CInfo%2FParameters&mode=interactive&buildNumber=12008&specName=Using%20Parameters%20Across%20All%20Stories&viewport=1200&browser=chrome

Difference:
Screenshot 2019-10-01 at 19 15 08

The diff also shows up in the canvas in chromatic... I'm puzzled

@ndelangen ndelangen mentioned this pull request Oct 1, 2019
Merged
ndelangen
ndelangen commented Oct 2, 2019
View reviewed changes
yarn.lock Outdated Show resolved Hide resolved
ndelangen
ndelangen commented Oct 2, 2019
View reviewed changes
yarn.lock Outdated Show resolved Hide resolved
@vercel vercel bot temporarily deployed to staging October 2, 2019 14:48 Inactive
@vercel vercel bot temporarily deployed to staging October 2, 2019 21:38 Inactive
@vercel vercel bot temporarily deployed to staging October 2, 2019 22:18 Inactive
@ndelangen ndelangen mentioned this pull request Oct 3, 2019
Merged
@ndelangen
Merge branch 'next' into tech/upgrade-chromatic
2a52b4c 
# Conflicts:
#	examples/dev-kits/package.json
#	examples/official-storybook/config.js
#	examples/official-storybook/package.json
#	package.json
#	yarn.lock
@ndelangen
Copy link
Member Author

@shilman I now know.

It's a babel / eslint / prettier change that made the space be removed.
The chromatic-cli alpha is using latest and greatest stuff, so that got into monorepo root node_modules and that make the snapshots different.

What I did was:
separately made an upgrades PR, verified it made the same impact. (I had to resolve some eslint changes).
I upgraded to storybook-chromatic 2.2.2 first.
On this version the symbolic linked 'built-storybook' was also already broken.
So that means my debug version wasn't causing that either.

I fixed that by using the prebuild examples script I wrote for now.sh for chromatic.

That just should just leave a few flaky acceptance test, the usual.

I'm confident now that The package is in a releasable state.

@ndelangen ndelangen added this to the 5.3.0 milestone Oct 3, 2019
@ndelangen ndelangen merged commit 5f1ee83 into next Oct 3, 2019
@ndelangen ndelangen deleted the tech/upgrade-chromatic branch October 3, 2019 22:58
@shilman shilman changed the title UPGRADE chromatic to test Build: Upgrade chromatic Oct 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@usulpro usulpro Awaiting requested review from usulpro

@igor-dv igor-dv Awaiting requested review from igor-dv

@tmeasday tmeasday Awaiting requested review from tmeasday

@shilman shilman Awaiting requested review from shilman

Assignees

@ndelangen ndelangen

Labels
dependencies
Projects
None yet
Milestone
5.3.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ndelangen @shilman @phated