Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addon-docs: Fix props table in no props case #8632

Merged
merged 1 commit into from Oct 30, 2019
Merged

Conversation

shilman
Copy link
Member

@shilman shilman commented Oct 30, 2019

Issue: #8123

What I did

Fix a bug in generalized props table handling where no rows are provided.

How to test

See Docs tab for the story Brand > Storybook Logo which is broken before this fix. (NOTE: we need a better way of testing docs tab?!)

@vercel
Copy link

vercel bot commented Oct 30, 2019

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/storybook/monorepo/nr5as731k
🌍 Preview: https://monorepo-git-8123-fix-no-props.storybook.now.sh

@shilman shilman added this to the 5.3.0 milestone Oct 30, 2019
Copy link
Member

@tmeasday tmeasday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok lgtm

@shilman shilman merged commit 2694435 into next Oct 30, 2019
@shilman shilman deleted the 8123-fix-no-props branch October 30, 2019 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants