Ndelangen/remove css usage #9003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/storybook/monorepo/vq640ga9x |
ndelangen
requested review from
alexandrebodin,
alterx,
CodeByAlex,
dangreenisrael,
igor-dv,
jbovenschen,
kazupon,
leonrodenburg,
saponifi3d,
shilman,
stijnkoopal,
theinterned,
usulpro and
z4o4z
as code owners
|
I did this be cause I was investigating the inclusion of all css of all languages of syntax-highlighter. Though I wasn't able to reproduce #8972 I did see huge blobs of string in our bundle. I figured it would save some bundle-size, because these blobs of string contained all sorts of comments that cannot be removed, but now they can. Packtracker seems to agree this is an improvement, though smaller than I had hoped. |
ndelangen
removed request for
theinterned,
kazupon,
shilman,
saponifi3d,
alterx,
leonrodenburg,
stijnkoopal,
dangreenisrael,
jbovenschen and
z4o4z
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: these styled.div`` string stay in the bundle as is, they cannot be minified, increasing the size of the bundle, especially in production mode.
What I did
I migrated them to use object notation